[MGNLCTS-129] fields in area dialog with createAreaNode:false are not exported Created: 19/Jan/21  Updated: 22/Sep/21  Resolved: 01/Feb/21

Status: Closed
Project: Content Translation Support
Component/s: None
Affects Version/s: 2.5
Fix Version/s: 2.5.1

Type: Bug Priority: Neutral
Reporter: Tomáš Gregovský Assignee: Antonín Juran
Resolution: Fixed Votes: 4
Labels: cs-bk, maintenance
Remaining Estimate: 0d
Time Spent: 0.5h
Original Estimate: Not Specified

Attachments: Text File MGNLCTS-129_fields_in_area_dialog_with_createAreaNode_false_are_not_exported.patch    
Issue Links:
Relates
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Maintenance 42
Story Points: 3

 Description   

Fields which are defined in area dialog which has set createAreaNode:false are not included in the export.

Tested on m6.2.5 (cloud 1)



 Comments   
Comment by Teresa Miyar [ 19/Jan/21 ]

Seems this was never implemented the method DialogBasedPropertiesToTranslateFinder#getCorrectArea gets the areas in the node and then matches them with the ones in the definition, since the node does not have the area it cannot match it with the ones in the definition to extract the dialog

Comment by Riste Drangovski [ 25/Jan/21 ]

There seems to be an issue connected with area nested in component.
When we create component with area that has crateAreaNode set to false, properties from the area dialog are not saved to component node but to the page node.
As far as I know area fields should be saved to component node, because area is defined on the component not on the template.
This issue happened in magnolia 6.2.5

Comment by Riste Drangovski [ 25/Jan/21 ]

I'm attaching a patch file that might help in solving current issue (excluding the above new issue related to area with no node nested in component).
Note: Patch is not fully tested!

Generated at Mon Feb 12 00:33:30 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.