[MGNLCTS-13] enable for use with Magnolia 4.5 Created: 15/Mar/12 Updated: 25/Mar/13 Resolved: 23/Mar/12 |
|
| Status: | Closed |
| Project: | Content Translation Support |
| Component/s: | None |
| Affects Version/s: | 1.0.4 |
| Fix Version/s: | 1.1 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Daniel Lipp | Assignee: | Daniel Lipp |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
Current version will throw NoClassDefFound exception because of changes to STK's SiteManager. We should either find a way to adapt code to be compliant with Magnolia 4.4 and 4.5 or branch the module. |
| Comments |
| Comment by Daniel Lipp [ 16/Mar/12 ] |
|
It was a wrong assumption we don't need to branch. Better testing revealed we have to adapt impl of DialogBasedNodeDataToTranslateFinder for 4.5. That's why we'll have to branch now. |
| Comment by Federico Grilli [ 23/Mar/12 ] |
|
content-translation-support.xml module descriptor should specify 4.5 versions for modules |