[MGNLCTS-16] Google Spreadsheet export doesn't properly consider fallbackLanguage Created: 20/Mar/12 Updated: 23/Mar/12 Resolved: 23/Mar/12 |
|
| Status: | Closed |
| Project: | Content Translation Support |
| Component/s: | None |
| Affects Version/s: | 1.0.4, 1.1 |
| Fix Version/s: | 1.0.5, 1.1 |
| Type: | Bug | Priority: | Major |
| Reporter: | Daniel Lipp | Assignee: | Daniel Lipp |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: |
| Description |
|
Even when fallbackLanguage for a site was changed, Google Spreadsheet export will always claim source language is 'en' (default fallbackLanguage): e.g. =GoogleTranslate("Events","en","en") |
| Comments |
| Comment by Daniel Lipp [ 20/Mar/12 ] |
|
In this particular case fix for 1.0-branch and trunk are not identical. Fix for trunk is more elegant and also easier to unit-test but it somehow breaks the API (new AbstractTranslationBundleWriter#init(OutputStream, Locale[], Locale has to be called now). |
| Comment by Philipp Bärfuss [ 23/Mar/12 ] |
|
If we add the source language to the google spreadsheet, we should probably also add it to the excel report. Or is there a reason to treat the two differently? |
| Comment by Philipp Bärfuss [ 23/Mar/12 ] |
|
OK, I see its for the automatic translation. But can we rename the parameter from ignoredHere to sourceLocale and just add @param javadoc to mention that it is not used? |
| Comment by Daniel Lipp [ 23/Mar/12 ] |
|
yes we can! |