[MGNLCTS-23] Make dependency on STK optional Created: 29/Aug/12  Updated: 23/Oct/14  Resolved: 23/Oct/14

Status: Closed
Project: Content Translation Support
Component/s: None
Affects Version/s: 1.1
Fix Version/s: 2.0.3

Type: Improvement Priority: Neutral
Reporter: Milan Divilek Assignee: Peili Liang
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLCTS-63 Support for Blossom dialogs Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

The module should not require STK to be installed. However, if STK is installed it should support its dialogs by automatically switching to the STK capable NodeDataToTranslateFinder implementation.

  • The maven dependency needs to be scoped as provided.
  • The module descriptor dependency needs to be flagged optional.
  • We should not bootstrap in the STK NodeDataToTranslateFinder by default at installation.

We should provide an implementation of NodeDataToTranslateFinder that uses reflection (via ComponentProvider.newInstance) to instantiate and delegate to the right implementation automatically based on which modules are installed. Should the user install STK or uninstall it the class will automatically switch implementation. Users won't need to fix the class name in config themselves. The class should be called AdaptiveNodeDataToTranslateFinder. This mechanism will be used to solve MGNLCTS-63.



 Comments   
Comment by Cheng Hu [ 22/Oct/14 ]

We discovered during review that there is still a dependency from CTS to STK, so that if you remove STK and try to use CTS, there will be an error.

The error is caused by CTS trying to use site definition to determine which languages need translations in the class ContentTransporter.

We will change this to use the default i18n mechanism DefaultI18NAuthoringSupport if STK is not available.

Generated at Mon Feb 12 00:32:27 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.