[MGNLDAM-1024] Setting width on name column has no effect Created: 05/May/22  Updated: 16/Aug/22  Resolved: 10/May/22

Status: Closed
Project: Magnolia DAM Module
Component/s: None
Affects Version/s: 3.0.15
Fix Version/s: 3.0.16

Type: Bug Priority: Neutral
Reporter: Raphael Falvo Assignee: Jesus Alonso
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Zip Archive EXTDAM-354-lm.zip     PNG File Screen Shot 2022-05-05 at 12.21.28.png     PNG File image-2022-05-06-15-47-50-945.png     PNG File image-2022-05-06-15-49-09-364.png    
Issue Links:
relation
is related to CELUM-40 Setting width on name column has no e... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: AuthorX Support
Sprint: AuthX 9
Story Points: 0.5
Team: AuthorX

 Description   

Setting the width on "name" column doesn't work, while on other column like "mimeType" it is working. You can find attached a light module with a decorator setting these 2 columns to a value set to 600, mimeType becomes much bigger while name is still very small.

From implementation perspective, name column is the only one having a custom column definition, the issue could be related to this :

info.magnolia.external.dam.s3.app.contentview.browser.column.S3NameColumnDefinition



 Comments   
Comment by Roman Kovařík [ 05/May/22 ]

Works for me

Comment by Raphael Falvo [ 06/May/22 ]

Hello rkovarik ,

I tried with last version of Magnolia (6.2.18) and last version of external dam (1.1.3), I don't have the same behavior than you. Any idea what could explain this behavior difference ?

 

 

 

Comment by Raphael Falvo [ 09/May/22 ]

Hey rkovarik ,

I guess I found out the root cause of this issue, in class info.magnolia.dam.app.contentview.list.AssetListPresenter, for any column having a name matching "name", maxWidth for this column is set to value 200.

https://git.magnolia-cms.com/projects/MODULES/repos/dam/browse/magnolia-dam-app/src/main/java/info/magnolia/dam/app/contentview/list/AssetListPresenter.java#100 

This makes a "name" column not configurable anymore, explicitly overriding the maxWidth in the configuration is not considered (probably set before it is set to 200)

What I don't understand is how it works for you, are you maybe running an unreleased version of Magnolia on which this piece of code would have changed in AssetListPresenter ?

Comment by Roman Kovařík [ 09/May/22 ]

Hi rfalvo,

I guess I found out the root cause of this issue, in class info.magnolia.dam.app.contentview.list.AssetListPresenter, for any column having a name matching "name", maxWidth for this column is set to value 200.

Roger, we can move it to the DAM project then.

What I don't understand is how it works for you, are you maybe running an unreleased version of Magnolia on which this piece of code would have changed in AssetListPresenter?

No idea, maybe a different browser, doesn't matter now as we know the root cause.

Comment by Jesus Alonso [ 10/May/22 ]

Code updated to not set maxWidth on name column.

Generated at Mon Feb 12 05:05:37 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.