[MGNLDAM-1158] DamApp opens all sub-apps by default Created: 18/Apr/23  Updated: 06/Jun/23

Status: Open
Project: Magnolia DAM Module
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Riste Drangovski Assignee: Unassigned
Resolution: Unresolved Votes: 2
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screenshot 2023-04-18 at 11.35.59.png     PNG File Screenshot 2023-04-18 at 11.36.46.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: AuthorX Support
Team: AuthorX

 Description   

info.magnolia.dam.app.DamApp by default opens all subApps no matter if subApp is closable or not.
info.magnolia.ui.framework.app.BaseApp which DamApp extends when started opens only non closable subApps, which I think is (and should be) default behaviour, closable subApps are intended to be started from some action.

So as far as I can see we are missing the filter:
".filter(subAppDescriptor -> !subAppDescriptor.isClosable())"
in info.magnolia.dam.app.DamApp#start method.



 Comments   
Comment by Riste Drangovski [ 19/Apr/23 ]

Additional clarification, isEnabledProviderBrowser should check if subAppDescriptor is BrowserDescriptor, but if it is not it should return true and fallback to "isClosable" filter.

Generated at Mon Feb 12 05:06:48 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.