[MGNLDAM-136] Dam#getAssetsByQuery(String) should be enhanced Created: 20/Feb/13  Updated: 12/Mar/21  Resolved: 12/Mar/21

Status: Closed
Project: Magnolia DAM Module
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Daniel Lipp Assignee: Unassigned
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MGNLDAM-70 Enable Dam to return a list of assets... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Dam#getAssetByQuery(String) (introduced with MGNLDAM-70) has several defects:

  • it's exposing access to the PersistenceLayer to "everybody". As I learned this is just because of backwards compatibility. This should explicitly be mentioned in javadoc
  • it's using deprecated Query.SQL - again we should mention in javadoc why we use deprecated query language in new code (backwards compatibility)
  • it's not forwarding potential exceptions (again to be backwards compatible?)
  • it should use QueryUtil


 Comments   
Comment by Tobias Mattsson [ 20/Feb/13 ]

Our options for improving this method is limited by the fact that it replaces functionality previously in STK (or DMS?), but we should do what we can and document why we keep it as we do.

Comment by Roman Kovařík [ 12/Mar/21 ]

No such code in latest https://git.magnolia-cms.com/plugins/servlet/search?q=project%3AMODULES%20repo%3Adam%20getAssetByQuery

Generated at Mon Feb 12 04:56:53 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.