[MGNLDAM-34] Improve logging in Dam - don't swallow stackTraces Created: 29/Nov/12  Updated: 11/Feb/13  Resolved: 05/Dec/12

Status: Closed
Project: Magnolia DAM Module
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0

Type: Bug Priority: Major
Reporter: Tobias Mattsson Assignee: Aleksandr Pchelintcev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLDAM-54 Fix Exceptions when rendering demo-pr... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

This is what the output looks like:

2012-11-29 14:35:20,668 ERROR info.magnolia.dam.Dam                             : /demo-project invalid identifier: dms
2012-11-29 14:35:20,905 ERROR info.magnolia.dam.Dam                             : /demo-project/content/01 teaserImg
2012-11-29 14:35:20,922 ERROR info.magnolia.dam.Dam                             : /demo-project/content/0 teaserImg
2012-11-29 14:35:20,936 ERROR info.magnolia.dam.Dam                             : /demo-project/content/00 teaserImg
2012-11-29 14:35:20,982 ERROR info.magnolia.dam.Dam                             : /demo-project/promos/0 teaserImg
2012-11-29 14:35:21,003 ERROR info.magnolia.dam.Dam                             : /demo-project/promos/00 teaserImg
2012-11-29 14:35:21,013 ERROR info.magnolia.dam.Dam                             : /demo-project/promos/01 teaserImg
2012-11-29 14:35:21,033 ERROR info.magnolia.dam.Dam                             : /demo-project/base/0/carouselItems/00 teaserImg
2012-11-29 14:35:21,044 ERROR info.magnolia.dam.Dam                             : /demo-project/base/0/carouselItems/01 teaserImg
2012-11-29 14:35:21,054 ERROR info.magnolia.dam.Dam                             : /demo-project/base/0/carouselItems/0 teaserImg
2012-11-29 14:35:21,067 ERROR info.magnolia.dam.Dam                             : /demo-project/base/0/carouselItems/02 teaserImg
2012-11-29 14:35:21,112 ERROR info.magnolia.dam.Dam                             : /demo-project/footer/0 footerImg
2012-11-29 14:36:01,753 ERROR info.magnolia.dam.Dam                             : /demo-project invalid identifier: dms
2012-11-29 14:36:01,914 ERROR info.magnolia.dam.Dam                             : /demo-project/content/01 teaserImg
2012-11-29 14:36:01,926 ERROR info.magnolia.dam.Dam                             : /demo-project/content/0 teaserImg
2012-11-29 14:36:01,939 ERROR info.magnolia.dam.Dam                             : /demo-project/content/00 teaserImg
2012-11-29 14:36:01,964 ERROR info.magnolia.dam.Dam                             : /demo-project/promos/0 teaserImg
2012-11-29 14:36:01,973 ERROR info.magnolia.dam.Dam                             : /demo-project/promos/00 teaserImg
2012-11-29 14:36:01,981 ERROR info.magnolia.dam.Dam                             : /demo-project/promos/01 teaserImg
2012-11-29 14:36:01,996 ERROR info.magnolia.dam.Dam                             : /demo-project/base/0/carouselItems/00 teaserImg
2012-11-29 14:36:02,005 ERROR info.magnolia.dam.Dam                             : /demo-project/base/0/carouselItems/01 teaserImg
2012-11-29 14:36:02,014 ERROR info.magnolia.dam.Dam                             : /demo-project/base/0/carouselItems/0 teaserImg
2012-11-29 14:36:02,022 ERROR info.magnolia.dam.Dam                             : /demo-project/base/0/carouselItems/02 teaserImg
2012-11-29 14:36:02,046 ERROR info.magnolia.dam.Dam                             : /demo-project/footer/0 footerImg

The code that logs it is in info.magnolia.dam.Dam#getAsset

} catch (RepositoryException e) {
    log.error(pathString+" "+e.getMessage());
}

The logging message gives no indication as to what the problem might be and even worse it doesn't log the exception itself so no stacktrace is available.



 Comments   
Comment by Aleksandr Pchelintcev [ 30/Nov/12 ]

Added more logging info for the problem.

Comment by Daniel Lipp [ 05/Dec/12 ]

Commit that fixed it for the printLogoImg: https://git.magnolia-cms.com/gitweb/?p=modules/standard-templating-kit.git;a=commitdiff;h=82ed3a392b9b7fbdca29f5c95e3799e60b5aaa60

Comment by Mikaël Geljić [ 05/Feb/13 ]

bulk operation to close 2012 resolved tickets in MGNLUI, MGNLDAM, MGNLWORKFLOW and SCRUM.

Generated at Mon Feb 12 04:55:54 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.