[MGNLDAM-382] DAM Upload component allows to upload image under image Created: 27/Jan/14  Updated: 03/Feb/14  Resolved: 03/Feb/14

Status: Closed
Project: Magnolia DAM Module
Component/s: None
Affects Version/s: None
Fix Version/s: 1.2.2

Type: Bug Priority: Neutral
Reporter: Aleksandr Pchelintcev Assignee: Aleksandr Pchelintcev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLUI-2596 DAM Upload component allows to upload... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Restrict upload button in asset choose dialog to be enabled for folders/root only.



 Comments   
Comment by Roman Kovařík [ 29/Jan/14 ]

Reopened: binary compatibility info.magnolia.dam.app.assets.field.UploadAssetActionRenderer.UploadAssetActionRenderer(UiContext, SimpleTranslator) is missing, should remain there and marked as deprecated.

Comment by Roman Kovařík [ 03/Feb/14 ]

Switching from In review back to Resolved because this ticket depends on MGNLUI-2596 which is still In progress.

Comment by Roman Kovařík [ 03/Feb/14 ]

First commit:
http://git.magnolia-cms.com/gitweb/?p=modules/dam.git;a=commitdiff;h=19ce123bc56b563186e3310b850127e211a172b5

Comment by Roman Kovařík [ 03/Feb/14 ]

Sorry to reopen again:

  1. New constructor shouldn't delegate to the deprecated one:
     @Inject
        public UploadAssetActionRenderer(UiContext layer, SimpleTranslator i18n, @Named(ChooseDialogEventBus.NAME)EventBus eventBus) {
            this(layer, i18n); <<
    
  2. Ideally, the old constructor should call new one (if possible).
  3. Would be cool if you can add unit test (I can still upload, not sure if I updated all necessary jars).
Generated at Mon Feb 12 04:59:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.