[MGNLDAM-447] In JcrAssetProvider, do not log stacktrace in case of ItemNotFoundException Created: 15/May/14  Updated: 23/Apr/21  Resolved: 23/Apr/21

Status: Closed
Project: Magnolia DAM Module
Component/s: DAM JCR Provider
Affects Version/s: 1.2.3
Fix Version/s: 3.0

Type: Improvement Priority: Neutral
Reporter: Jozef Chocholacek Assignee: Unassigned
Resolution: Fixed Votes: 1
Labels: logging
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

In JcrAssetProvider.getAsset(String assetIdentifier) the stacktrace is logged on RepositoryException. That means the stacktrace is logged also in case, when the asset has not been found (e.g. has not been activated yet, but the page pointing to it yes). This causes quite high log-pollution in case that - for any reason - an non-existent asset is referenced from a frequently visited page.

It would be better if just the error message is logged in case of ItemNotFoundException, and stacktrace only in case of other RepositoryException.



 Comments   
Comment by Jan Haderka [ 23/Apr/21 ]

fixed as side effect of working on MAGNOLIA-7606

Generated at Mon Feb 12 04:59:56 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.