[MGNLDAM-476] Allow asset upload when an asset or folder is selected Created: 18/Jun/14 Updated: 19/Jun/19 Resolved: 05/Aug/15 |
|
| Status: | Closed |
| Project: | Magnolia DAM Module |
| Component/s: | User Interaction |
| Affects Version/s: | 2.0 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Antti Hietala | Assignee: | Mikaël Geljić |
| Resolution: | Won't Fix | Votes: | 1 |
| Labels: | usability, ux | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 7d 1h | ||
| Original Estimate: | 7h | ||
| Attachments: |
|
||||||||||||||||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Sprint: | Sprint 4 (Basel) | ||||||||||||||||
| Story Points: | 1 | ||||||||||||||||
| Description |
|
Usability improvement for direct asset upload. Make the upload action available even when an existing asset is selected. It doesn't make sense to users why they can't upload an asset. The default assumption shouldn't be that the user is trying to replace the existing asset or build a hierarchy. They just want to upload the asset quickly. This is a common use case when overwriting teaser assets. The Assets chooser dialog won't allow direct upload when the prior asset is selected, which it is by default. Comparable example: In Google Drive, you can have an existing document selected but you can still upload a new one. The new doc won't replace the selected one or go under it. It will become a sibling. |
| Comments |
| Comment by Andreas Weder [ 24/Mar/15 ] |
|
I've been asked to comment. Strictly speaking, our actions apply to the currently selected item only. In this case, uploading an asset should do something with the selected asset. I would be fine with this proposed change under the condition that we also change the name of the action to "upload new asset", at least in this case, to make things clear. What I dislike, however, is that we have similar cases in other apps, which we would have to allow as well to remain consistent. Almost every app except for "Pages" has similar cases, where an "Add folder" or "Add item" action could be allowed as well. If this is a frequent use case, I'd still vote "yes", albeit with a small margin. |
| Comment by Sang Ngo Huu [ 21/Apr/15 ] |
|
Dear Andreas, There are my implementations, please let me know if I'm wrong: I've pushed the code into Thanks, |
| Comment by Aleksandr Pchelintcev [ 21/Apr/15 ] |
|
Re-opened because:
|
| Comment by Andreas Weder [ 24/Apr/15 ] |
|
Ok, had a look and quick discussion with Sang. Thanks for the nice idea of an "add folder" action. Here's a short summary of what we agreed upon:
apchelintcev I've told Sang I'd be fine this time to leave the "add folder" button in the same ticket, for pragmatic reasons. I've asked him to create separate tickets for added functionality in the future. I hope you're fine with that - it's meant to be an exception to a strict rule |
| Comment by Aleksandr Pchelintcev [ 03/May/15 ] |
|
awedermp I don't mind at all, let it be added to the changeset. There just were other reasons to re-open, so I thought splitting the changes would be beneficial for both assignee and the reviewer. Maybe then the ticket title should be re-stated accordingly. |
| Comment by Aleksandr Pchelintcev [ 03/Jun/15 ] |
|
You shouldn't have replaced the info.magnolia.ui.framework.action.ConfirmationActionDefinition with info.magnolia.module.dependencies.action.DependencyAwareConfirmationActionDefinition as the latter is only available in EE version. |
| Comment by Sang Ngo Huu [ 04/Jun/15 ] |
|
That is my mistake when exporting bootstrap file. I reverted. |
| Comment by Jan Haderka [ 16/Jun/15 ] |
|
| Comment by Federico Grilli [ 02/Jul/15 ] |
|
A couple of minor remarks:
|
| Comment by Jaroslav Simak [ 09/Jul/15 ] |
|
Since you had to do some changes also in the MGNLUI project (branch |
| Comment by Sang Ngo Huu [ 10/Jul/15 ] |
|
I created ticket |
| Comment by Mikaël Geljić [ 10/Jul/15 ] |
|
This is madness. It's not clear what the heck was the outcome of this, and how much sense it makes now; the gap is so huge between ticket description, comments, and more decisions during implementation...
In my opinion, this just drifted too far: it brings behavior inconsistency between workbench in apps vs. in choose-dialog. |
| Comment by Mikaël Geljić [ 05/Aug/15 ] |
|
Ticket status is not up to date: this should be unscheduled and either moved back to open/backlog, or even closed as "won't fix". As common as the described use-case may be, uploading siblings raises questions in purely hierarchical (tree) or unordered (list, thumbnail) views. This story will eventually be captured by general content-view improvements at some point. |