[MGNLDAM-49] Cleanup code introduced with MGNLDAM-19 Created: 03/Dec/12  Updated: 25/Jun/13  Resolved: 06/May/13

Status: Closed
Project: Magnolia DAM Module
Component/s: None
Affects Version/s: 1.0
Fix Version/s: 1.0

Type: Improvement Priority: Major
Reporter: Daniel Lipp Assignee: Aleksandr Pchelintcev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MGNLDAM-19 Find all the uses of an asset Closed
relation
is related to MGNLDAM-52 Drop AssetEditorField, AssetEditorUti... Closed
is related to MGNLDAM-48 Improve Javadoc Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   

As review took place only now, the original ticket MGNLDAM-19 couldn't be reopened. Hence a follow up ticket was created:
AssetEditorUtils: drop it

  • don't implement imaging operation in dam - reuse from imaging module
    CropImageAction: adapt
  • never uses passed in constructor args LocationController & Node -> drop them
    AssetEditorSubAppViewImpl: adapt
  • view should not itself query JCR (AssetContentNodeStreamSource#getStream())
    -> should be implemented in a deeper layer (e.g. to be able to re-use e.g. from commands or Webservices)
  • use JcrConstants instead hardcoding "jcr:content" etc.
  • no e.printStackTrace() (#118)
  • session name "dam" is already defined in Dam#DAM_REPOSITORY -> use that constant rather then hardcoded same value (about 5 places in dam-app-assets)

Generated at Mon Feb 12 04:56:03 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.