[MGNLDAM-491] Update to mgnl 5.3.1 fails if there is deleted (not published) file in DAM Created: 21/Jul/14 Updated: 01/Jul/15 Resolved: 10/Feb/15 |
|
| Status: | Closed |
| Project: | Magnolia DAM Module |
| Component/s: | None |
| Affects Version/s: | 2.0.1 |
| Fix Version/s: | 2.0.8 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Tomáš Gregovský | Assignee: | Federico Grilli |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | support | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Patch included: |
Yes
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
I am working on migration of corporate website to 5.3.1 and there was missing asset in DAM which was deleted but this deletion wasn't published. and this file fails whole update process with this error: 2014-07-21 16:52:05,511 WARN .setup.for2_0.UpdateDamAssetFileNamePropertiesTask: Asset '/corporate-dms/resources/tech-briefs/Finance-Whitepaper' has no extension defined. 2014-07-21 16:52:05,536 ERROR info.magnolia.module.InstallContextImpl : > Error while installing or updating dam-app module. Task 'Update the Asset fileName property' failed. (NullPointerException: ) java.lang.NullPointerException at info.magnolia.dam.app.setup.for2_0.UpdateDamAssetFileNamePropertiesTask$DamFileNamePropertyVisitor.visit(UpdateDamAssetFileNamePropertiesTask.java:93) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:656) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:658) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:658) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:658) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:658) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:651) at info.magnolia.dam.app.setup.for2_0.UpdateDamAssetFileNamePropertiesTask.execute(UpdateDamAssetFileNamePropertiesTask.java:70) at info.magnolia.module.ModuleManagerImpl.applyDeltas(ModuleManagerImpl.java:514) at info.magnolia.module.ModuleManagerImpl.installOrUpdateModule(ModuleManagerImpl.java:496) at info.magnolia.module.ModuleManagerImpl$1.doExec(ModuleManagerImpl.java:274) at info.magnolia.context.MgnlContext$VoidOp.exec(MgnlContext.java:414) at info.magnolia.context.MgnlContext$VoidOp.exec(MgnlContext.java:411) at info.magnolia.context.MgnlContext.doInSystemContext(MgnlContext.java:385) at info.magnolia.module.ModuleManagerImpl.performInstallOrUpdate(ModuleManagerImpl.java:268) at info.magnolia.module.ui.ModuleManagerWebUI$2.run(ModuleManagerWebUI.java:124) at java.lang.Thread.run(Thread.java:695) 2014-07-21 16:52:05,539 ERROR info.magnolia.module.ui.ModuleManagerWebUI : Could not perform installation: null java.lang.NullPointerException at info.magnolia.dam.app.setup.for2_0.UpdateDamAssetFileNamePropertiesTask$DamFileNamePropertyVisitor.visit(UpdateDamAssetFileNamePropertiesTask.java:93) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:656) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:658) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:658) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:658) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:658) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:651) at info.magnolia.dam.app.setup.for2_0.UpdateDamAssetFileNamePropertiesTask.execute(UpdateDamAssetFileNamePropertiesTask.java:70) at info.magnolia.module.ModuleManagerImpl.applyDeltas(ModuleManagerImpl.java:514) at info.magnolia.module.ModuleManagerImpl.installOrUpdateModule(ModuleManagerImpl.java:496) at info.magnolia.module.ModuleManagerImpl$1.doExec(ModuleManagerImpl.java:274) at info.magnolia.context.MgnlContext$VoidOp.exec(MgnlContext.java:414) at info.magnolia.context.MgnlContext$VoidOp.exec(MgnlContext.java:411) at info.magnolia.context.MgnlContext.doInSystemContext(MgnlContext.java:385) at info.magnolia.module.ModuleManagerImpl.performInstallOrUpdate(ModuleManagerImpl.java:268) at info.magnolia.module.ui.ModuleManagerWebUI$2.run(ModuleManagerWebUI.java:124) at java.lang.Thread.run(Thread.java:695) 2014-07-21 16:52:05,540 ERROR info.magnolia.module.InstallContextImpl : > Could not perform installation: null java.lang.NullPointerException at info.magnolia.dam.app.setup.for2_0.UpdateDamAssetFileNamePropertiesTask$DamFileNamePropertyVisitor.visit(UpdateDamAssetFileNamePropertiesTask.java:93) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:656) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:658) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:658) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:658) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:658) at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:651) at info.magnolia.dam.app.setup.for2_0.UpdateDamAssetFileNamePropertiesTask.execute(UpdateDamAssetFileNamePropertiesTask.java:70) at info.magnolia.module.ModuleManagerImpl.applyDeltas(ModuleManagerImpl.java:514) at info.magnolia.module.ModuleManagerImpl.installOrUpdateModule(ModuleManagerImpl.java:496) at info.magnolia.module.ModuleManagerImpl$1.doExec(ModuleManagerImpl.java:274) at info.magnolia.context.MgnlContext$VoidOp.exec(MgnlContext.java:414) at info.magnolia.context.MgnlContext$VoidOp.exec(MgnlContext.java:411) at info.magnolia.context.MgnlContext.doInSystemContext(MgnlContext.java:385) at info.magnolia.module.ModuleManagerImpl.performInstallOrUpdate(ModuleManagerImpl.java:268) at info.magnolia.module.ui.ModuleManagerWebUI$2.run(ModuleManagerWebUI.java:124) at java.lang.Thread.run(Thread.java:695) |
| Comments |
| Comment by Marcus Büttner [ 06/Nov/14 ] |
|
This NPE still occurs with dam 2.0.5. |
| Comment by Marcus Büttner [ 06/Nov/14 ] |
|
Patch to avoid the NPE |
| Comment by Federico Grilli [ 10/Feb/15 ] |
|
Thanks Marcus for providing the patch! |