[MGNLDAM-553] RenditionAwareAssetProvider breaks design of DAM API Created: 06/Mar/15 Updated: 01/Jul/15 Resolved: 10/Mar/15 |
|
| Status: | Closed |
| Project: | Magnolia DAM Module |
| Component/s: | DAM API |
| Affects Version/s: | 2.0.7 |
| Fix Version/s: | 2.0.8 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Magnolia International | Assignee: | Magnolia International |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||
| Epic Link: | Extract STK functionality | ||||||||||||||||||||||||||||||||
| Description |
|
RenditionAwareAssetProvider adds a method that looks like a shortcut for the above, except that it also prevents using the whole system correctly
: AssetProviderRegistry.getRendererFor(myAsset, MediaType.JPEG).render(myAsset, MediaType.JPEG, "myRenditionName") (i see the verbosity/redundancy, for which we could add a shortcut in APR) I'd like to deprecate this interface ASAP, and remove it in 2.1, since it just creates noise and confusion. STK has an implementation of this, which should also go. In addition, we'll need:
|
| Comments |
| Comment by Magnolia International [ 10/Mar/15 ] |
|
commits are in merging/ |
| Comment by Espen Jervidalo [ 10/Mar/15 ] |
|
info.magnolia.dam.api.AbstractAssetProvider use import instead of FQN |