[MGNLDAM-584] Dam link field label Created: 06/May/15  Updated: 12/Mar/21  Resolved: 12/Mar/21

Status: Closed
Project: Magnolia DAM Module
Component/s: Design
Affects Version/s: 1.2, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6, 1.2.7, 1.2.8, 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4, 2.0.5, 2.0.6, 2.0.7
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Christian Ringele Assignee: Unassigned
Resolution: Obsolete Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File AssetLink label.png    
Issue Links:
Relates
relates to MGNLUI-2954 LinkField shows preview section even ... Closed
causality
caused by MGNLUI-3901 Link Field Label: Ugly styling Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

See attachment.

How long will it take until we resolve this?
I see it since Magnolia 5.0...



 Comments   
Comment by Mikaël Geljić [ 31/May/16 ]

It seems the generic fix in the UI (MGNLUI-2954) hasn't applied to the AssetLinkFieldDefinition.

Let's take the occasion to check what this field does differently from the plain LinkField, to see if it's still needed. So far I found:

  • The factory doesn't even extend the LinkFieldFactory
  • The definition specifies a configurable property basePropertyName, which is not—or not anymore—consumed by the factory.
    • these basePropertyNames smell a bit the pre-transformer era to me
  • found: chooseDialogCallback is a tiny bit different, casts selection to info.magnolia.dam.api.ItemKey
    • I had discussed a generic solution few months back w/ cmeier (in the context of resources); not sure if we parked something for 5.5?

Deprecation is not far off the corner, you guess my next question: where is it still used! only seeing right now it's case of the dam-external chooser

Generated at Mon Feb 12 05:01:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.