[MGNLDAM-633] Requesting an AssetRendition for an unknown ItemKey shouldn't result in two warnings in the log Created: 12/Jan/16  Updated: 19/May/22  Resolved: 19/May/22

Status: Closed
Project: Magnolia DAM Module
Component/s: DAM Templating
Affects Version/s: 2.1.1
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Nils Breunese Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

If an AssetRendition is requested via DamTemplatingFunctions#getRendition, which can also be damfn.getRendition in a template, and not item can be found, this results in two warnings in the log and a null return value:

WARN   info.magnolia.dam.templating.functions.DamTemplatingFunctions 03.01.2016 19:57:00 -- The following ItemKey 'media' generated exceptions when trying to retrieve the associated Item : ItemKey is not valid.
WARN   info.magnolia.dam.templating.functions.DamTemplatingFunctions 03.01.2016 19:57:00 -- Trying to get asset with item key media returned null.

The first warning seems to come from the private getItem method, and the second one from the getRendition method which calls the getItem method.

I think it would be better if the private getItem method would not log a warning and return null, but would throw an exception. That exception could be catched by getRendition and logged there (or it could be (re)thrown, but calls from damfn probably wouldn't like that).



 Comments   
Comment by Roman Kovařík [ 19/May/22 ]

Hello,

This ticket is now marked as closed due to one of the following reasons:

  • A long period of inactivity
  • Uses an old or Beta version of an application, module, or framework that we no longer support
  • The issue is no longer reproducible or has been fixed in later versions

If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you.

Thank you,
The Magnolia Team

Generated at Mon Feb 12 05:01:45 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.