[MGNLDAM-797] Special chars not being controlled in node name through the 'Update zip file' action Created: 27/Jun/19  Updated: 12/Mar/21  Resolved: 12/Mar/21

Status: Closed
Project: Magnolia DAM Module
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Carlos Cantalapiedra Assignee: Unassigned
Resolution: Cannot Reproduce Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Steps to reproduce:

  1. create a zip file with name test characters].zip including some files inside
  2. open assets app and import zip file

You get an error like:

Caused by: org.apache.jackrabbit.spi.commons.conversion.MalformedPathException: '/test characters]' is not a valid path. '￿' not a valid name character.

There must be a processing of the path name in order to avoid non-allowed characters. Special case is blank, which is allowed but ends up causing issues when linking to resources(see SUPPORT-10123)

Problem appears here (line 80):

info.magnolia.commands.impl.BaseRepositoryCommand.getJCRNode(Context)
if (StringUtils.isNotEmpty(getUuid())) {
            node = session.getNodeByIdentifier(getUuid());
        } else {
            node = session.getNode(getPath());
        }

The return of getPath() should be processed in order to control illegal chars



 Comments   
Comment by Roman Kovařík [ 12/Mar/21 ]

Can't reproduce on latest (affected version is not filled) in both

 

Generated at Mon Feb 12 05:03:22 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.