[MGNLDAM-815] For non-images, the word thumbnail obstructs asset names Created: 12/Dec/19 Updated: 16/Nov/20 Resolved: 14/Jan/20 |
|
| Status: | Closed |
| Project: | Magnolia DAM Module |
| Component/s: | None |
| Affects Version/s: | 3.0 |
| Fix Version/s: | 3.0 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Martin Drápela | Assignee: | Adam Siska |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 3h | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Sprint: | UI Framework 14 | ||||||||
| Story Points: | 3 | ||||||||
| Description |
|
There's two issues in fact, related to the thumbnails: 1) For non-image assets, the word thumbnail obstructs asset name:
The word comes from the IMG alt attribute:
2) The source for the thumbnail links to a non-existing HTML page, instead of an img file a) (for audio): src="/magnoliaAuthor/dam/travel-demo/audio.html" b) (for video) src="/magnoliaAuthor/dam/travel-demo/video.html"
2019-12-12 08:43:06,813 WARN info.magnolia.dam.core.download.DamDownloadServlet: Could not retrieve an asset based on the following pathInfo /travel-demo/audio.html java.lang.IllegalArgumentException: Node '/travel-demo/audio' is not defining an asset but another item type at info.magnolia.dam.jcr.JcrAssetProvider.createAsset(JcrAssetProvider.java:167) ~[magnolia-dam-jcr-3.0-SNAPSHOT.jar:?] at info.magnolia.dam.jcr.JcrAssetProvider.getAsset(JcrAssetProvider.java:156) ~[magnolia-dam-jcr-3.0-SNAPSHOT.jar:?] For sure the src cannot be an HTML page. The HTML SPECS say: (https://www.w3.org/TR/html52/semantics-embedded-content.html#the-img-element)
Solution proposal (should fix both issues described) If we cannot generate asset thumbnails for these types of assets from the assets themselves (for sure not for the audios) we should use our own icons instead, from our Icons font:
https://documentation.magnolia-cms.com/display/DOCS61/Icons#Icons-Imageicons |
| Comments |
| Comment by Roman Kovařík [ 15/Jan/20 ] |
|
asiska Could you check if mov video preview is visible in firefox (for me it doesn't work also in Safari, just in chrome)? |
| Comment by Adam Siska [ 15/Jan/20 ] |
|
Works for me in Firefox (on grca-over15-432.mp4 assets). |