[MGNLDAM-875] Upload assets create untitled nodes regardless of provided asset name Created: 04/Sep/20  Updated: 21/Jan/21  Resolved: 18/Jan/21

Status: Closed
Project: Magnolia DAM Module
Component/s: None
Affects Version/s: 3.0.3
Fix Version/s: None

Type: Bug Priority: Medium
Reporter: Martin Haderka Assignee: Unassigned
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: 10m
Original Estimate: Not Specified
Environment:

MGNL dx-core bundle: magnolia-dx-core-demo-webapp-6.2.3-20200904.094337-21-tomcat-bundle


Issue Links:
Relates
relates to MGNLDAM-919 Asset names are different in the Asse... Closed
duplicate
is duplicated by CONTTAGS-106 New asset name not filled correctly Closed
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Epic Link: Migrate Assets
Story Points: 5

 Description   

Steps to reproduce

1. Open "Assets app"
2. Click on "Upload asset"
3. Upload file (e.g., "image.png")
4. Click "Commit"

1. Open "Assets app"
2. Click on "Upload asset"
3. Upload file (e.g., "image.png")
4. Set Asset name to "test image"
5. Click "Commit"

Expected results

New asset with

  • nodeName: "image.png"
  • name: "image"

New asset with

  • nodeName: "image.png"
  • name: "test image"

Actual results

New asset with

  • nodeName: "untitled"
  • name: "untitled"

New asset with

  • nodeName: "untitled"
  • name: "test image"

Workaround

Rename item

Other notes

  • Issue is reproducible on Magnolia dx-core budle:
    magnolia-dx-core-demo-webapp-6.2.3-20200904.094337-21-tomcat-bundle
  • CE bundle isn't affected

Development notes

  • there is a save action on DX triggered by the tag field/tag manager
  • we might consider introducing setTags() method to tag manager which doesn't save the session
    • this is probably a bug in tags behavior - tags assume you want to save immediately, which is not the case, investigate on that front.
  • or should JcrSessionWrapper ignore session saving before #commit?
  • or reevaluate why the asset commit action has to be so complicated (e.g. checking if item is new, a lot of conditions with different behaviours)

Generated at Mon Feb 12 05:04:09 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.