[MGNLDAM-890] writePermissionRequired is not set in actions as in old assets app Created: 25/Sep/20  Updated: 06/Jan/21  Resolved: 05/Jan/21

Status: Closed
Project: Magnolia DAM Module
Component/s: None
Affects Version/s: 3.0.3
Fix Version/s: 3.0.5

Type: Bug Priority: Neutral
Reporter: Mercedes Iruela Assignee: Adam Siska
Resolution: Fixed Votes: 0
Labels: 623
Remaining Estimate: Not Specified
Time Spent: 40m
Original Estimate: Not Specified

Attachments: PNG File 57-assets-app-read-only.png     PNG File 62Assets-app-read-only.png     PNG File 62damnotallowederror.png    
Issue Links:
Relates
relates to MGNLTEST-116 Provide new persona with limited access Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Migrate Assets
Sprint: UI FW 19
Story Points: 1

 Description   

writePermissionRequired is used to check writting permissions in a node. In the old assets app, it disabled all the actions that required write permisions. In the new dam app, not all the actions that requires writting permissions in the node are including it, it leads to actions available when it shouldn't and errors when trying to execute this actions.

This is the status of the action bar when a read-only permissions assigned to a node in new dam app:

This is how it used to be in 5.7.*:

Steps to reproduce (bundle with travel-demo)

  1. As superuser, go to the Security App and configure user eric readonly permissions for Dam > /tours (role: travel-demo-editor).
  2. Login as eric
  3. Go to dam app and click on /tours. See that almost all the actions are available. Choose one asset: Edit the asset > Edit the dialog and save.

Expected result

When opening dam app and click on /tours(readonly), actions that require write permissions shouldn't be available. Same when clicking on an asset within /tours

Current result

You can select an action that requires writting permissions. An error comes up:

Workaround

Decorate the dam app and add writePermissionRequired: true to all the actions that need it.

Acceptance criteria

  • It is just a matter of configuration, however the dam app should be configured in a correct way as it used to be in the old assets app in 5.7.


 Comments   
Comment by Roman Kovařík [ 21/Oct/20 ]

I guess

  • case 1 - user is allowed to write - action enabled
  • case 2 - user is not allowed to write - action disabled
    Does it make sense?
Generated at Mon Feb 12 05:04:18 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.