[MGNLDAM-893] "Show Version" in Assets app allows to edit and throws error Created: 06/Oct/20  Updated: 16/Dec/21  Resolved: 16/Nov/21

Status: Closed
Project: Magnolia DAM Module
Component/s: None
Affects Version/s: 3.0.3, 3.0.4
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Monica Damborenea Assignee: Chuong Doan Huy
Resolution: Fixed Votes: 0
Labels: VN-Maintenance, cm-team-support, maintenance
Remaining Estimate: Not Specified
Time Spent: 2d 50m
Original Estimate: Not Specified

Attachments: HTML File show versions save    
Issue Links:
Problem/Incident
Relates
relates to MGNLPN-440 View detail subapp has "Save changes"... Closed
dependency
depends upon MGNLUI-5593 Nodes are editable in view and versio... Closed
duplicate
is duplicated by MGNLDAM-972 Show version allows saving Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Date of First Response:
Epic Link: Migrate Assets
Sprint: Assets Maintenance 1, Assets Maintenance 2
Story Points: 5

 Description   

If you click on "Show Version" in the Assets app, it is possible to edit it but then an error is thrown when trying to save.

Steps to reproduce

  1. Go to the Assets app, edit an asset and publish it
  2. Now you have the option to see the versions, select the asset, and click on "Show versions"
  3. Notice you are able to edit the version
  4. Click on save and an error is thrown (show versions save)

In our docs, we mention that when selecting the "Show version" action it is not possible to edit. If you check other apps, such as the pages app, and click on "Show version" you can see a read-only version of the page. You are not allowed to edit.

Furthermore, in Magnolia 5.7, it was not possible to edit the version, you could restore it if necessary or even download it in the case of the assets app.

Expected results

  • Based on our docs and how the versioning usually works, it should not be possible to edit and save a version of an asset. We should instead see a read-only version of the asset.
  • If allowing our customers to edit the version of the asset is intended, then the error should be fixed.

Actual results
It is possible to edit but an error is thrown when saving

 

Options alternative

Global solution

  • custom read-only detail view (extend default java class for detail view with all fields disabled)

Local solution (dropped for a global one)

  • create a view for the asset version with read-only fields 


 Comments   
Comment by Roman Kovařík [ 03/Nov/21 ]

For the record, there is https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/pull-requests/1877/diff which should help with this.

Comment by Nguyen Phung Chi [ 16/Nov/21 ]

FYI, this ticket is solved by MGNLUI-5593.

Thanks yen.lactue for QA.

Generated at Mon Feb 12 05:04:20 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.