[MGNLDAM-940] Dam detail subApp should have presentable tab caption Created: 22/Feb/21  Updated: 26/Feb/21  Resolved: 25/Feb/21

Status: Closed
Project: Magnolia DAM Module
Component/s: None
Affects Version/s: None
Fix Version/s: 3.0.6

Type: Improvement Priority: Neutral
Reporter: Milan Divilek Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File CleanShot 2021-02-25 at 20.00.28.png    
Issue Links:
Issue split
split from MGNLUI-6550 Detail subApp should have presentable... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: UI framework implementation
Sprint: UI FW 22
Story Points: 0

 Description   

https://demo.magnolia-cms.com/.magnolia/admincentral#app:dam:jcrDetail;/travel-demo/social-icons/google-plus.png:edit

Expected results

I can easily identify the edited item. .

Actual results

The caption defaults to full path which does not fit the size of the label. 

Workaround

Hover the caption to see the full path.

Or on case of JCR datasources, reconfigure the detail datasource with describedByProperty=jcrName (or title, name)



 Comments   
Comment by Šimon Demočko [ 25/Feb/21 ]

Hi mdivilek, I think Title would be more representable here than name.  See 

Could we change it to use Title in this case?

(edit) Okay, I found this comment. Still, could we override the default method so it would become possible to use Title and fallback to name when empty?

Comment by Milan Divilek [ 26/Feb/21 ]

As discussed the title property doesn't have to be set, but the name property is automatically created when creating the asset and that's why we decided to stick with name property.
Asset app uses default JcrDatasource and JcrItemDescriber. To fallback to another property than path we would need custom implementation for the asset app. And it could be also confusing why other apps fallbacks to path, but the asset to name property.

Comment by Šimon Demočko [ 26/Feb/21 ]

We also considered implementing describeByProperty to accept an array of values from most specific to least specific, falling back to the next one, if the first one isn't available. This would require more changes and at this moment didn't seem like a worthwhile effort.

Generated at Mon Feb 12 05:04:47 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.