[MGNLDAM-956] Make the AssetRegistry check validation of each provider Created: 06/Apr/21 Updated: 26/Apr/21 Resolved: 20/Apr/21 |
|
| Status: | Closed |
| Project: | Magnolia DAM Module |
| Component/s: | None |
| Affects Version/s: | 3.0.6 |
| Fix Version/s: | None |
| Type: | Task | Priority: | Neutral |
| Reporter: | Ilgun Ilgun | Assignee: | Jesus Alonso |
| Resolution: | Obsolete | Votes: | 0 |
| Labels: | maintenance | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 50m | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
[ ]*
Make sure the asset chooser is still functioning correctly
[ ]*
Introduce validation e.g. commerceDefinition isEnabled into asset provider definitions
[ ]*
Introduce a method in registry to fetch enabled ones
[ ]*
Use them throughout the system
[ ]*
Also make S3 and Bynder disabled by default
[ ]*
Question whether JCR should be disabled or not?
|
||||||||
| Task DoR: |
Empty
|
||||||||
| Release notes required: |
Yes
|
||||||||
| Date of First Response: | |||||||||
| Sprint: | Maintenance 53 | ||||||||
| Description |
|
We don't want the registry to spit out disabled definitions. For once, we don't have disabled definitions and no way of filtering them, that should be solved. Also, the customers of the asset registry should be able to filter those disabled definitions and use this information e.g. in the asset chooser to their benefits.
User story:
|
| Comments |
| Comment by Roman Kovařík [ 07/Apr/21 ] |
|
We might introduce AssetProvider#isEnabled. AbstractAssetProvider might just return boolean property. ExternalAssetProvider might override #isEnabled with e.g. credentials check.
We might not need a separate method:
I guess because of the compatibility, the default impl of #isEnabled it should return true for JCR or any custom customer's provider (at least on M6.x) |
| Comment by Federico Grilli [ 20/Apr/21 ] |
|
Fixed by |