[MGNLDAM-985] Allow to modify path in damLinkField Created: 13/Apr/21  Updated: 14/Oct/21  Resolved: 03/Sep/21

Status: Closed
Project: Magnolia DAM Module
Component/s: None
Affects Version/s: 3.0.9
Fix Version/s: 3.0.10

Type: Improvement Priority: Blocker
Reporter: Viet Nguyen Assignee: Roman Kovařík
Resolution: Fixed Votes: 2
Labels: cs-bk, maintenance, ui-team-support
Remaining Estimate: Not Specified
Time Spent: 0.2h
Original Estimate: Not Specified

Attachments: File InPageDialog2.mov     File SelectNew.mov     File Untitled 2.mov    
Issue Links:
Cloners
is cloned by MGNLUI-6834 linkField#converterClass only takes e... Closed
is cloned by MGNLUI-6835 Converted link fields are not editable Closed
causality
dependency
is depended upon by MGNLUI-6835 Converted link fields are not editable Closed
supersession
supersedes MGNLUI-6839 Implement clipboard to copy values be... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Documentation update required:
Yes
Date of First Response:
Epic Link: Improve Content Linking
Sprint: UI FW 35, UI FW 36
Story Points: 5

 Description   

Steps:

  1. Navigate to a dialogue with link field to DAM
  2. Select an image
  3. See the path in the dialogue field
  4. Try to edit this path by hand

Current:

  1. Path cannot be changed
  2. It is not possible to copy and paste a path into the field (was possible before)

Expected:

  1. Path can be changed
  2. It is possible to paste a path into this field (used by power users)

This work previously and now it does not in 6.2.7.

 

Developer notes:

  • not possible to showOptions by default because of performance issue
  • when allowing text input with showOptions=false the editor would have to fill in format jcr:UUID //bad UX
  • use plain JCR link field (JCR assets only) for converted dialog (customers could use this config in new framework as well) //estimated
  • we don't support text input in damLinkField, document/communicate this


 Comments   
Comment by Roman Kovařík [ 13/Apr/21 ]

Should be possible with textInputAllowed=true and showOptions=true.

Comment by Stefan Huettenrauch [ 13/Apr/21 ]

Hi Roman,

we've tried the options you named.

Yes, we can edit the path field, BUT
NO, the edit has no effect and when saving the dialogue, the entered value is not used.
Also, no options have been shown to us when starting to type a path.

(tested on 6.2.6)

Could you please check on your end.

Comment by Roman Kovařík [ 13/Apr/21 ]

Hi shuettenrauch,

The new showOptions property is available since MGNLUI-6530. Just tried to validate: Untitled 2.mov
The same comment describes how to achieve this in previous version.

Hope that helps
Roman

Comment by Roman Kovařík [ 13/Apr/21 ]

Hey Viet,
just tried on demo in a page dialog InPageDialog2.mov as well.

Comment by Stefan Huettenrauch [ 13/Apr/21 ]

thanks for your fast answer.

we will upgrade to 6.2.7 in the next week and then be back with our results.

Comment by Jonathan Ayala [ 16/Apr/21 ]

This issue has also been reported in SUPPORT-12918.

Steps to reproduce

It can be reproduced with mtk components in pages app:

  1. Add Link Field in a page of basic template
  2. Edit manually the value
  3. Add a Text and Image component
  4. Try to edit manually the value of the image link field

Results:

In 2) field is editable, i.e. Link field (to pages) is generated as editable.
In 4) field is not editable, i.e. Link field (to assets) is generated as non editable.

Although both components are defined almost equally, generation of LinkField in {info.magnolia.ui.form.field.definition.migration.LinkFieldDefinitionConverter<T>}} differs when target workspace is dam, which is probably what is causing the distinction.

Comment by Roman Kovařík [ 01/Oct/21 ]

damLinkField with textInputAllowed=true now accepts path to an asset as direct input (has to be explicitly enabled).
textInputAllowed is set automatically for old dialog definitions converted at runtime.

Generated at Mon Feb 12 05:05:14 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.