[MGNLDAMEXT-21] Make dam-ext specific implementation work also with JCR Created: 23/Oct/14  Updated: 24/Oct/14  Resolved: 24/Oct/14

Status: Closed
Project: DAM Extensions
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0

Type: New Feature Priority: Neutral
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   
  • Merge CumulusLinkTransformer into DamExt
  • add configurable basePropertyName to AssetLinkFieldDefinition
  • adjust info.magnolia.damext.liberated.app.field.AssetLinkFieldFactory to work also with JcrItems.


 Comments   
Comment by Jan Haderka [ 23/Oct/14 ]

I might be missing something, but why do we check in Translator in one place whether ID starts w/ "jcr" and in another w/ "jcr:"? Shouldn't it be the same (latter) in both places?

Comment by Roman Kovařík [ 24/Oct/14 ]

Only exception which remains when switching from cumulus back to magnolia asset (the other way around is without exception):

2014-10-24 08:50:13,901 ERROR n.integration.contentconnector.JcrContentConnector: Failed to obtain JCR id for fragment: Not an absolute path: cumulus.$Categories/Asset-Typen/Bilder/Fotos/BMP/Balloon Race.BMP
javax.jcr.RepositoryException: Not an absolute path: cumulus.$Categories/Asset-Typen/Bilder/Fotos/BMP/Balloon Race.BMP
	at org.apache.jackrabbit.core.session.SessionItemOperation.perform(SessionItemOperation.java:189)
	at org.apache.jackrabbit.core.session.SessionState.perform(SessionState.java:216)
	at org.apache.jackrabbit.core.SessionImpl.perform(SessionImpl.java:361)
	at org.apache.jackrabbit.core.SessionImpl.nodeExists(SessionImpl.java:1138)
	at info.magnolia.jcr.wrapper.DelegateSessionWrapper.nodeExists(DelegateSessionWrapper.java:272)
	at info.magnolia.jcr.wrapper.DelegateSessionWrapper.nodeExists(DelegateSessionWrapper.java:272)
	at info.magnolia.jcr.wrapper.DelegateSessionWrapper.nodeExists(DelegateSessionWrapper.java:272)
	at info.magnolia.jcr.decoration.ContentDecoratorSessionWrapper.nodeExists(ContentDecoratorSessionWrapper.java:115)
	at info.magnolia.jcr.wrapper.DelegateSessionWrapper.nodeExists(DelegateSessionWrapper.java:272)
	at info.magnolia.jcr.decoration.ContentDecoratorSessionWrapper.nodeExists(ContentDecoratorSessionWrapper.java:115)
	at info.magnolia.ui.vaadin.integration.jcr.JcrItemUtil.getItemId(JcrItemUtil.java:137)
	at info.magnolia.ui.vaadin.integration.contentconnector.JcrContentConnector.getItemIdByUrlFragment(JcrContentConnector.java:113)
	at info.magnolia.ui.vaadin.integration.contentconnector.JcrContentConnector.getItemIdByUrlFragment(JcrContentConnector.java:63)
	at info.magnolia.ui.dialog.choosedialog.ChooseDialogPresenterImpl.start(ChooseDialogPresenterImpl.java:139)
	at info.magnolia.ui.contentapp.ContentApp.openChooseDialog(ContentApp.java:102)
	at info.magnolia.ui.contentapp.ContentApp.openChooseDialog(ContentApp.java:83)
	at info.magnolia.ui.framework.app.AppControllerImpl.openChooseDialog(AppControllerImpl.java:413)
	at info.magnolia.ui.framework.app.AppControllerImpl.openChooseDialog(AppControllerImpl.java:403)
	at info.magnolia.damext.liberated.app.field.AssetLinkFieldFactory$1.buttonClick(AssetLinkFieldFactory.java:94)
Generated at Mon Feb 12 00:40:49 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.