[MGNLDATA-138] Unable to change dialog for an item Created: 17/Nov/11  Updated: 07/Dec/15  Resolved: 07/Dec/15

Status: Closed
Project: Magnolia Data Module (closed)
Component/s: None
Affects Version/s: 1.6.4
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Tobias Mattsson Assignee: Philipp Bärfuss
Resolution: Outdated Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

When I change the dialog in config:/modules/data/config/types/category@dialogName from category to dataDialog (which exists). I get the exception below.

While debugging it i've found that there seems to be an error in GenericDataAdminTreeConfig line 248 where it gives the itemTypeName. This gets passed to the javascript object mgnl.data.DataTree and its method edit on line 41 which expects a dialog.

java.lang.NullPointerException
	info.magnolia.cms.util.ExtendingContentWrapper.<init>(ExtendingContentWrapper.java:83)
	info.magnolia.cms.util.ExtendingContentWrapper.wrapIfNeeded(ExtendingContentWrapper.java:131)
	info.magnolia.cms.util.ExtendingContentWrapper.wrap(ExtendingContentWrapper.java:282)
	info.magnolia.cms.util.ContentWrapper.getChildByName(ContentWrapper.java:230)
	info.magnolia.module.data.dialogs.TypeSelectDataDialog.createDialog(TypeSelectDataDialog.java:211)
	info.magnolia.module.admininterface.DialogMVCHandler.getDialog(DialogMVCHandler.java:457)
	info.magnolia.module.admininterface.DialogMVCHandler.renderHtml(DialogMVCHandler.java:417)
	info.magnolia.cms.servlets.MVCServlet.doPost(MVCServlet.java:124)
	info.magnolia.cms.servlets.MVCServlet.doGet(MVCServlet.java:69)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
	info.magnolia.cms.filters.ServletDispatchingFilter.doFilter(ServletDispatchingFilter.java:119)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:84)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:84)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:84)
	info.magnolia.cms.filters.CompositeFilter.doFilter(CompositeFilter.java:66)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	info.magnolia.cms.filters.VirtualUriFilter.doFilter(VirtualUriFilter.java:69)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	info.magnolia.module.cache.executor.Bypass.processCacheRequest(Bypass.java:57)
	info.magnolia.module.cache.filter.CacheFilter.doFilter(CacheFilter.java:122)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:60)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	info.magnolia.cms.i18n.I18nContentSupportFilter.doFilter(I18nContentSupportFilter.java:75)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	info.magnolia.module.cache.filter.GZipFilter.doFilter(GZipFilter.java:73)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:60)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:84)
	info.magnolia.cms.security.BaseSecurityFilter.doFilter(BaseSecurityFilter.java:64)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	info.magnolia.cms.security.LogoutFilter.doFilter(LogoutFilter.java:88)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:60)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	info.magnolia.cms.security.auth.login.LoginFilter.doFilter(LoginFilter.java:77)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:84)
	info.magnolia.cms.filters.CosMultipartRequestFilter.doFilter(CosMultipartRequestFilter.java:86)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:60)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	info.magnolia.cms.filters.ContentTypeFilter.doFilter(ContentTypeFilter.java:102)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	info.magnolia.cms.filters.ContextFilter.doFilter(ContextFilter.java:120)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	info.magnolia.cms.filters.CompositeFilter.doFilter(CompositeFilter.java:66)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
	info.magnolia.cms.filters.MgnlMainFilter.doFilter(MgnlMainFilter.java:105)
	info.magnolia.cms.filters.MgnlMainFilter.doFilter(MgnlMainFilter.java:216)


 Comments   
Comment by Jan Haderka [ 17/Nov/11 ]

Data module assumes dialog name to be the same as type name in many places. This is definitvely not correct, however it makes it easier to find out dialog one needs to update to edit properties for given type.

Comment by Michael Mühlebach [ 07/Dec/15 ]

Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
Given that the this issue has seen no attention for quite a while and belongs to an outdated version, we're not going to address this issue any more. Instead we will focus on issues with a higher impact and more votes.
Under the assumption this issue is together with it's associated version no longer relevant, I'm going to close it to set expectations so the issue doesn't stay open for ages with no updates. If it is still relevant please feel free to open a new issue in the appropriate project.

Generated at Mon Feb 12 05:11:44 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.