[MGNLDATA-164] Remove all classes referencing AdminTreeMVCHandler and use info.magnolia.commands.chain.Command instead of org.apache.commons one Created: 28/Jan/13 Updated: 14/Mar/13 Resolved: 06/Feb/13 |
|
| Status: | Closed |
| Project: | Magnolia Data Module (closed) |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 2.0 |
| Type: | Task | Priority: | Major |
| Reporter: | Federico Grilli | Assignee: | Daniel Lipp |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoR: |
Empty
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
This is needed following the Commands refactoring see also |
| Comments |
| Comment by Daniel Lipp [ 06/Feb/13 ] |
|
TypeDialog is removed but still referenced in bootstrap files -> lead to: 2013-02-06 09:10:13,620 WARN dule.admininterface.ConfiguredDialogHandlerManager: Can't find dialog handler class info.magnolia.module.data.dialogs.TypeDialog |
| Comment by Daniel Lipp [ 06/Feb/13 ] |
|
Another side effect of the latest changes committed to this ticket: in old adminCentral (that's still around) you'll get InvalidTreeHandlerExceptions when navigating to any of the submenus of "Data" - except Config (Dialog). Example when selecting Data/Types: HTTP Status 500 - type Exception report message description The server encountered an internal error () that prevented it from fulfilling this request. exception java.lang.RuntimeException: info.magnolia.module.admininterface.InvalidTreeHandlerException: No tree handler for [dataType] found |
| Comment by Federico Grilli [ 06/Feb/13 ] |
|
Worked around the CNFE by reintroducing TypeDialog class with the code referencing the removed tree handlers commented out. As long as data module is not migrated to a Content app (see https://magnolia.atlassian.net/browse/BL-140) I think we will have to live with such workarounds. As to the errors due to the missing data tree handlers, they happen in old AdminInterface which I think is reasonable to expect. |