[MGNLDATA-164] Remove all classes referencing AdminTreeMVCHandler and use info.magnolia.commands.chain.Command instead of org.apache.commons one Created: 28/Jan/13  Updated: 14/Mar/13  Resolved: 06/Feb/13

Status: Closed
Project: Magnolia Data Module (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 2.0

Type: Task Priority: Major
Reporter: Federico Grilli Assignee: Daniel Lipp
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLDATA-168 Bootstrap files refer to deleted types Closed
is causing MGNLSTK-1134 Bootstrap files refer to deleted types Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

This is needed following the Commands refactoring see also MAGNOLIA-4786. In particular, AdminTreeMVCHandler references org.apache.commons.chain.Command which is no longer in the cp now thus causing compilation errors. In any case, all the old UI has to be removed sooner or later.



 Comments   
Comment by Daniel Lipp [ 06/Feb/13 ]

TypeDialog is removed but still referenced in bootstrap files -> lead to:

2013-02-06 09:10:13,620 WARN dule.admininterface.ConfiguredDialogHandlerManager: Can't find dialog handler class info.magnolia.module.data.dialogs.TypeDialog
java.lang.ClassNotFoundException: info.magnolia.module.data.dialogs.TypeDialog
at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at groovy.lang.GroovyClassLoader.loadClass(GroovyClassLoader.java:696)
at groovy.lang.GroovyClassLoader.loadClass(GroovyClassLoader.java:564)

Comment by Daniel Lipp [ 06/Feb/13 ]

Another side effect of the latest changes committed to this ticket:

in old adminCentral (that's still around) you'll get InvalidTreeHandlerExceptions when navigating to any of the submenus of "Data" - except Config (Dialog).

Example when selecting Data/Types:

HTTP Status 500 -

type Exception report

message

description The server encountered an internal error () that prevented it from fulfilling this request.

exception

java.lang.RuntimeException: info.magnolia.module.admininterface.InvalidTreeHandlerException: No tree handler for [dataType] found
info.magnolia.module.cache.filter.CacheFilter.doFilter(CacheFilter.java:165)
info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
info.magnolia.cms.i18n.I18nContentSupportFilter.doFilter(I18nContentSupportFilter.java:76)
info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
info.magnolia.cms.filters.RangeSupportFilter.doFilter(RangeSupportFilter.java:86)
info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
info.magnolia.cms.security.BaseSecurityFilter.doFilter(BaseSecurityFilter.java:60)
info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)

Comment by Federico Grilli [ 06/Feb/13 ]

Worked around the CNFE by reintroducing TypeDialog class with the code referencing the removed tree handlers commented out. As long as data module is not migrated to a Content app (see https://magnolia.atlassian.net/browse/BL-140) I think we will have to live with such workarounds. As to the errors due to the missing data tree handlers, they happen in old AdminInterface which I think is reasonable to expect.

Generated at Mon Feb 12 05:11:59 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.