[MGNLDATA-192] Automatic activation of imported items fails with "Parent content /categorization/34 is not yet activated ..." Created: 27/Aug/13  Updated: 17/Sep/13  Resolved: 04/Sep/13

Status: Closed
Project: Magnolia Data Module (closed)
Component/s: None
Affects Version/s: 1.7.6
Fix Version/s: 1.7.7, 2.1

Type: Bug Priority: Neutral
Reporter: Frank Sommer Assignee: Jaroslav Simak
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

If you activate the feature of automatic activation after an data import, the following error message could occur:

Error while deactivating all data of type dataBase. info.magnolia.cms.exchange.ExchangeException: 1 error detected: 
Message received from subscriber: Parent content /categorization/34 is not yet activated or you do not have write access to it. Please activate the parent content before activating children and ensure you have appropriate rights on public

The reason is, that the Set of the imported node uuids is not sorted. So the DataActivateAllCommand tries to activate the childs before its parents. The super class contains an node sorting method, but this one will be never reached. See the execute method of BaseDataAllCommand.



 Comments   
Comment by Jan Haderka [ 03/Sep/13 ]

Funny, you would write this after seeing what retrieval of nodes inside of comparator does elsewhere ... pls make this comparator caching path.

Comment by Jaroslav Simak [ 03/Sep/13 ]

Actually, there is almost no difference with cache and without it, i did some performance tests:

With Cache
Nodes: 110100
140 ms
114 ms
113 ms
114 ms
216 ms
111 ms
Without Cache
Nodes: 110100
137 ms
111 ms
111 ms
111 ms
111 ms
110 ms
Comment by Jan Haderka [ 03/Sep/13 ]

How many other things did you have in the item cache (i.e. who else was accessing your instance and writing some content while your test was running)? I guess none. Also how big were your nodes - how many props they had. Item cache is about 30 MB by default if your nodes are small enough and server is not accessed for any other purpose you would indeed see very little difference. Unfortunately real life scenario is never that simple.

Generated at Mon Feb 12 05:12:15 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.