[MGNLDATA-32] Invalid link to file in dialog Created: 30/Jun/08 Updated: 02/Jul/14 Resolved: 28/Jul/08 |
|
| Status: | Closed |
| Project: | Magnolia Data Module (closed) |
| Component/s: | None |
| Affects Version/s: | 1.1 |
| Fix Version/s: | 1.2.1 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Wolfgang Habicht | Assignee: | Jan Haderka |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Description |
|
| Comments |
| Comment by Philipp Bracher [ 01/Jul/08 ] |
|
The data module provides an extra control for binary data (files). I don't remember its exact name, but please check /modules/data/controls. |
| Comment by Wolfgang Habicht [ 01/Jul/08 ] |
|
If I use the controlType 'dataFile' I get the same invalid url |
| Comment by Philippe Marschall [ 27/Jul/08 ] |
|
Actually the bug is in the module magnolia-gui. The bug report is a bit unclear. The bug is only visible for something for which a preview image can not be shown like a PDF. This is because the class DialogFile does not consistently use the mehtod #getFileURI which DataFileControl overrides. There is the additional issue that DialogFile does not set the file extension for the download URI which makes Magnolia return the wrong content type. For something like a PDF this results in the binary data of the PDF being displayed. Steps to Reproduce
Expected Behavior
Observed Behavior
Fix attached DialogFile should be reviewed for more such bugs. |
| Comment by Jan Haderka [ 28/Jul/08 ] |
|
Thanks for patch. Applied as r17067. |