[MGNLDATA-68] Allow creation of types and data nodes in a hierarchy. Created: 18/Sep/09 Updated: 15/Sep/15 Resolved: 23/Nov/09 |
|
| Status: | Closed |
| Project: | Magnolia Data Module (closed) |
| Component/s: | None |
| Affects Version/s: | 1.4 |
| Fix Version/s: | 1.4 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Bert Leunis | Assignee: | Jan Haderka |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | Not Specified | Time Spent: | Not Specified |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Attachments: |
|
||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||
| Sub-Tasks: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Patch included: |
Yes
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Description |
|
See this entry in the wiki for the description of the desired functionality: http://wiki.magnolia-cms.com/display/DEV/Magnolia+Data+Module+Extensions+-+Mixed+type+hierarchies. There are many changes to accommodate the new functionality. Here are the main changes:
|
| Comments |
| Comment by Jan Haderka [ 29/Sep/09 ] |
|
After upgrade to 1.4-snapshot (with the patch applied) from 1.3.2 I get NPE when trying to display the types tree. Have you seen this? It must be some of the changes to the tree or tree configuration and will need probably also update task to make sure the modified tree still works after the upgrade. Unfortunately it is difficult to follow the changes in the code since there are also many purely formatting changes giving the false positives. You might consider next time to do the first all formatting changes (if necessary) and put them in one patch, and only then start changing the code and have purely code related changes in another patch (too late for this now). |
| Comment by Jan Haderka [ 29/Sep/09 ] |
|
Every time I try to create a sub type, the message pops up that the saving of the subtype failed, but the type is actually saved and visible upon refresh of the type tree. Is that something you didn't know how to fix or is it suppose to be working fine? |
| Comment by Bert Leunis [ 29/Sep/09 ] |
|
The NPE in the types tree can be solved when the file config.modules.data.trees.dataType.xml will be bootstrapped. I did not change the VersionHandler because I didn't quit get the way it works. At a fresh install, the extra tasks (for newer versions than 1.0) are not bootstrapped until a second startup of the webapp. Not knowing how to fix this properly I left this for someone who does. (I guess you Jan). |
| Comment by Jan Haderka [ 29/Sep/09 ] |
|
OK, no problem. Are there any other places/points where you were not sure what to do? |
| Comment by Bert Leunis [ 29/Sep/09 ] |
|
The subtype error sounds weird. I had a similar problem with the renaming of nodes. The code in info.magnolia.module.data.trees.GenericDataAdminTree.renameNode(String) does give an alert saying it can't rename, but then the rename went well. I do not understand what the code in the if-block is supposed to do. Without that block, no problem while renaming. The rootpath must not be editable in the dialog for the subtype. This is done in info.magnolia.module.data.dialogs.TypeDialog.createDialog(Content, Content). Was it not in the patch? Has the configuration the correct class for the dialog? |
| Comment by Bert Leunis [ 29/Sep/09 ] |
|
Things to do still:
|
| Comment by Jan Haderka [ 30/Sep/09 ] |
|
The dialog issue was caused by the rejected chunk of the patch that I have missed (and surprisingly enough the class compiled without it), so it is solved now.
|
| Comment by Bert Leunis [ 01/Oct/09 ] |
|
The trees for the subtypes are needed when you create or edit a subtype. After saving, a tree with the name of that subtype will be opened in AdminCentral, so that's why that tree-definition has to exist. Unless you can think of some way to avoid that. Maybe there is a clue in About the 'new item' option for a terminal item: I "solved" this in the TypeSelectDialog: when there are no items to add, a message is displayed in the dialog window. The code for the tree is quite complicated already, I didn't want to add much more to it. And it does work now. But... if you feel this is how you want it... I won't stop you. |
| Comment by Jan Haderka [ 02/Oct/09 ] |
|
Well spotted. It is indeed a case. I've created a sub task and linked it to I'm nearly done with the review and update tasks. Just one more question: why do you set the configurationClass also for the "data" tree (i.e. the tree that is linked to the JCR browser) ... it doesn't seem necessary unless I'm missing something obvious? |
| Comment by Bert Leunis [ 02/Oct/09 ] |
|
No, you are right, the configurationClass is not needed there. You can get rid of that. |
| Comment by Jan Haderka [ 02/Oct/09 ] |
|
The patch is committed now. Few technical comments:
|
| Comment by Bert Leunis [ 05/Oct/09 ] |
|
Thanks for all the work Jan, and apologies for all the inconveniences.
|
| Comment by Michael Mühlebach [ 15/Sep/15 ] |
|
This ticket was closed because former resolved tickets are deemed to be closed now. If this assumption is untrue in this particular case please feel free to reopen the ticket again. |