[MGNLDATA-70] DataDialog limits should not hardcode the return value of getJsExecutedAfterSaving Created: 28/Sep/09 Updated: 15/Sep/15 Resolved: 23/Nov/09 |
|
| Status: | Closed |
| Project: | Magnolia Data Module (closed) |
| Component/s: | None |
| Affects Version/s: | 1.3.2 |
| Fix Version/s: | 1.4.1 |
| Type: | Bug | Priority: | Major |
| Reporter: | Will Scheidegger | Assignee: | Jan Haderka |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Patch included: |
Yes
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
DataDialog.getJsExecutedAfterSaving() returns a hardcoded String: "opener.mgnl.data.DataTree.reloadAfterEdit('" + this.itemType + "', '" + this.path + "')". This will get the opener to load the standard tree for the node type at the given path. But if the dialog was called from somewhere else (e.g. custom tree) then the user is out of luck. Therefore there should be a way to simply reload/refresh the opener page in the state it was before. The patch below changes the behavior of DataDialog.getJsExecutedAfterSaving() so that it only returns the JS to load the standard tree when nothing else has been specified. This seems to work for the standard data trees and for custom trees. However I have not tested this for other situations (e.g. opening the dialog from a custom page). |
| Comments |
| Comment by Jan Haderka [ 23/Nov/09 ] |
|
Applied in r29937. Thanks for the patch. |
| Comment by Michael Mühlebach [ 15/Sep/15 ] |
|
This ticket was closed because former resolved tickets are deemed to be closed now. If this assumption is untrue in this particular case please feel free to reopen the ticket again. |