[MGNLDATA-89] dialog don't display Icon properly Created: 16/Nov/09  Updated: 16/Sep/15  Resolved: 19/Nov/09

Status: Closed
Project: Magnolia Data Module (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 1.4

Type: Bug Priority: Major
Reporter: Boris Kraft Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

OSX, Safari 4


Attachments: Text File DataFileControl.java.patch     PNG File Picture 1.png     Text File config.modules.data.dialogs.dataType.xml.patch    
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Date of First Response:

 Description   

The Magnolia dialogs for data module "types" allows you to select an icon that represents a data type. This icon is not rendered in the dialog. It seems as if only a border is rendered but not the icon itself. See attached screenshot



 Comments   
Comment by Bert Leunis [ 17/Nov/09 ]

The src for the image is something like: /contextPath/modules/data/config/types/animal/mammal/cow/image.png.
To get it working it should be: /contextPath/dataModule/typeImages/animal/mammal/cow/image.png

See:

  • the mappings defined at Configuration: server/URI2RepositoryMapping/dataModuleTypeImages
  • info.magnolia.module.data.TypeDefinition.getIcon()
    for more information.

The controlType in the dataType dialog of this field should not be "file" but "dataFile". The patch for the bootstrap file is attached.
The class info.magnolia.module.data.controls.DataFileControl needs a bit of new code too. The patch for this class is attached.

Please make sure that for the next version of the Data Module the file config.modules.data.dialogs.dataType.xml is bootstrapped.
Let Jan have a look at the changed DataFileControl class. I think it will not hurt existing data, but he might know better.

Comment by Philipp Bärfuss [ 19/Nov/09 ]

I will not change the DataFileControl but but have an other subclass of it for the type icon. The code is otherwise hard to understand as it adds special treatment of a corner case

Comment by Michael Mühlebach [ 16/Sep/15 ]

This ticket was closed because former resolved tickets are deemed to be closed now. If this assumption is untrue in this particular case please feel free to reopen the ticket again.

Generated at Mon Feb 12 05:11:15 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.