[MGNLDEMO-103] Demo advanced form including Multi-Step Created: 16/Sep/15 Updated: 11/Nov/16 Resolved: 06/Jan/16 |
|
| Status: | Closed |
| Project: | Magnolia Demo Projects |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 0.9 |
| Type: | Story | Priority: | Major |
| Reporter: | Christopher Zimmermann | Assignee: | Evzen Fochr |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 2d 4h 25m | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||
| Epic Link: | Travel Demo | ||||||||||||||||||||||||||||
| Sprint: | Kromeriz 25 | ||||||||||||||||||||||||||||
| Story Points: | 8 | ||||||||||||||||||||||||||||
| Description |
|
Why: Advanced forms are an important part of demoing Magnolia. The form should be designed to include all of the out-of-the-box form elements. The form should include three steps. And show off the available validation. When a user clicks the Book Tour button on a tour page, the demo should no longer launch the modal popup. It should rather link to a new page (not in the navigation) containing the form. SPEC: Features that are demonstrated Features not demonstrated The fields are speced in this googledoc - |
| Comments |
| Comment by Jan Haderka [ 17/Sep/15 ] |
|
Please provide list of the fields for each of the pages in the form and conditions (if any) to switch to next page or skip or ... |
| Comment by Christopher Zimmermann [ 12/Nov/15 ] |
|
Please see updated description and linked google doc for specification. |
| Comment by Christopher Zimmermann [ 16/Nov/15 ] |
|
To implementor: Spec is a suggestion - lets discuss if you have ideas for improvement of how advanced form features are demo'd. |
| Comment by Michael Mühlebach [ 16/Nov/15 ] |
|
Might it be an idea to look at the following two tickets in the context of this one? |
| Comment by Evzen Fochr [ 09/Dec/15 ] |
|
According to docu page upload file component in multistep forms this is only available on the last step and thats REVIEW. |
| Comment by Christopher Zimmermann [ 17/Dec/15 ] |
|
Personal Details Page: "breadcrumb" at top should not be all CAPS when one is on that step. Title field should have length:small Remove Credit Card field - not necessary for this demo. CSS for Review page. |
| Comment by Evzen Fochr [ 17/Dec/15 ] |
|
I suggest change here to: .form-row .form-item-m { width:188px; }.form-row .form-item-l { width:388px; }88 is 100 - 10 for margin and - 2 for borders |
| Comment by Christopher Zimmermann [ 21/Dec/15 ] |
|
For the form - please change the messages: 2nd message changed because it is also used on the Personal details page when there is a validation problem - and then the message is confusing because you did not try to book the tour yet. On final review step, change label from "Submit" > "Confirm Booking". Otherwise everything looks good to me. |
| Comment by Christopher Zimmermann [ 05/Jan/16 ] |
|
Problem due to https://jira.magnolia-cms.com/browse/MGNLFORM-255
|
| Comment by Christopher Zimmermann [ 05/Jan/16 ] |
|
On the "Personal Info" page, the layout is too wide for narrow smart phones due to Possible fix is to change this width to 288px. Note that this will make the form not line up with the "Previous Step" , "Next Step" buttons. |
| Comment by Jan Haderka [ 05/Jan/16 ] |
|
Shouldn't that kind of things be taken care of by bootstrap rather than us forcing the width for all possible variations? |
| Comment by Christopher Zimmermann [ 05/Jan/16 ] |
|
I know what you mean - but using the "vanilla bootstrap" that we are using means we would need to add additional boostrap css classes to the form rows and form items, like "col-md-6". I think the current approach is ok as it is leveraging the "form-item-s", "form-item-m", "form-item-l" classes that the form module provides. Maybe we could come up with some fancier css based on percentages and mediaqueries (as bootstrap does) - but I think its pretty straightforward and gets the job done. |
| Comment by Christopher Zimmermann [ 06/Jan/16 ] |
|
Do not integrate until linked ticket https://jira.magnolia-cms.com/browse/MGNLFORM-255 is fixed. |