[MGNLDEMO-110] magnolia-travel-demo-marketing-tags should not depend on multisite module Created: 05/Oct/15 Updated: 21/Oct/15 Resolved: 20/Oct/15 |
|
| Status: | Closed |
| Project: | Magnolia Demo Projects |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 0.8 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Milan Divilek | Assignee: | AntonĂn Juran |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 1.5h | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: | |
| Epic Link: | Travel Demo |
| Sprint: | Kromeriz 15 |
| Story Points: | 2 |
| Description |
|
Marketing tags are EE standard module. So demo should not depend on multisite module. Dependency to multisite module is there just because module bootstraps |
| Comments |
| Comment by Philip Mundt [ 06/Oct/15 ] |
|
We could use an optional dependency to solve this issue (and only modify multisite site when it's installed). |
| Comment by Evzen Fochr [ 20/Oct/15 ] |
|
Reviewed, but Stash error denied my approval. |
| Comment by Philip Mundt [ 20/Oct/15 ] |
|
Added a new comment/task to the PR. Please make sure to also rebase (in this case squash) the commits! |