[MGNLDEMO-144] Make the w3 validation proof: Mainly the search result page. Created: 09/Feb/16  Updated: 19/Apr/16  Resolved: 16/Feb/16

Status: Closed
Project: Magnolia Demo Projects
Component/s: magnolia-travels
Affects Version/s: 0.8, 0.8.1, 0.9
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Christian Ringele Assignee: Unassigned
Resolution: Duplicate Votes: 0
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File searchResults.ftl.png    
Issue Links:
duplicate
duplicates MGNLDEMO-135 Search result page might brake layout... Closed
relation
is related to MAGNOLIA-6548 SearchHTMLExcerpt: Should also check ... Accepted
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Checking the travels demo's search result page w3 validation errors show up:
https://validator.w3.org/nu/?doc=https%3A%2F%2Fdemopublic.magnolia-cms.com%2Ftravel%2Fmeta%2Fsearch-results.html%3FqueryStr%3Dtours

One reason is a missing <span> in the searchResults.ftl (see print screen).
But also because it uses result html snippets within "<div class=\"excerpt\">" created by info.magnolia.jackrabbit.lucene.SearchHTMLExcerpt there are invalid strcutres creaded, such as P-tags around a div:

<p class="list-group-item-text"><div class="excerpt"><span class="excerpt-fragment">... erhalten.</p>
           below <p>Do you have a question about one of our <strong>tours</strong>? Would you like to customize a tour - or looking for a trip you just</span><span class="excerpt-fragment">... on our website?</p>

            <p>Do you have a question about how our <strong>tours</strong> work, about a booking you&rsquo;ve placed or about payment? Or are you on ...</span></div></p>

We need to check if this can be resolved nicer.


Generated at Mon Feb 12 05:16:45 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.