[MGNLDEMO-155] Decouple travel-demo from tours Created: 31/Mar/16  Updated: 08/Apr/16  Resolved: 06/Apr/16

Status: Closed
Project: Magnolia Demo Projects
Component/s: None
Affects Version/s: None
Fix Version/s: 0.11

Type: Task Priority: Neutral
Reporter: Jan Haderka Assignee: Ilgun Ilgun
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 1.25d
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLDEMO-154 Hidden circular-dependency between tr... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Sprint: Basel 38
Story Points: 3

 Description   
  • All workaround for templates & dialog definitions for other modules

Timebox: Clean up as much as possible in this timeframe and create specific tickets for the rest



 Comments   
Comment by Ilgun Ilgun [ 05/Apr/16 ]

pmundt found during QA of MGNLDEMO-154:

Unfortunately, there is more: page /travel/about/careers.html contains contents (all six? assets in the image gallery) from the tour module but unfortunately the contents are bootstrapped by the travel-demo module, causing exception when tours module is not installed.

2016-04-05 08:39:17,264 WARN  ia.dam.templating.functions.DamTemplatingFunctions: The following ItemKey 'jcr:5843f97c-a825-40af-855b-f02483c6f354' generated exceptions when trying to retrieve the associated Item : No Asset found for ItemKey <info.magnolia.dam.api.ItemKey@9d2f7acb>
2016-04-05 08:39:17,264 WARN  ia.dam.templating.functions.DamTemplatingFunctions: Trying to get asset with item key jcr:5843f97c-a825-40af-855b-f02483c6f354 returned null.

I guess those contents (the whole gallery) should be bootstrapped by the tours module, the tricky bit being ordering the sub-node appropriately after clean install/update. When updating the deltas, please also make sure to bump all delta of all modules (see https://git.magnolia-cms.com/projects/MODULES/repos/demo-projects/commits/58f37d59dea8488877e36a2527a711723a320c1b for similar commit)!

Ideally, we should check there are no similar issue left.

Generated at Mon Feb 12 05:16:52 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.