[MGNLDEMO-160] Separate i18n UI messages and template messages in Travel-Demo Created: 02/May/16 Updated: 24/Mar/17 Resolved: 24/Mar/17 |
|
| Status: | Closed |
| Project: | Magnolia Demo Projects |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Martin DrĂ¡pela | Assignee: | Unassigned |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
1) The main issue: At the end of https://documentation.magnolia-cms.com/display/DOCS/Types+of+translatable+text we recommend that app designers keep i18n messages for UI and for templates into two separate .properties files in a message bundle. This best practice is not followed in Travel Demo included in Magnolia 5.4.6 where both the UI messages and the Template messages are stored in one file: module-travel-demo-messages_en.properties 2) A corollary to this issue is that <bundle-name><templates><locale>.properties to distinguish them from UI messages, which could remain in <bundle-name>_<locale>.properties (Alternatively, to make it consistent, the recommended filename for UI messages could be 3) Furthermore module-travel-demo-messages_de.properties 4) A side note: navigation.login=Log in in Shouldn't this file also include template keys like navigation.login=Anmelden |
| Comments |
| Comment by Martin DrĂ¡pela [ 02/May/16 ] |
|
The point is how to interpret the suggestion "Create separate message bundles for user interface labels and template labels." By definition, a message bundle is "a collection of .properties files". Having two separate .properties files for each language version would mean eventually doubling the number of .properties files in each i18n folder. An alternative (and narrower) interpretation of a "message bundle" would be to treat a group of i18n keys stored within a single .properties file as a bundle. |
| Comment by Antti Hietala [ 24/Mar/17 ] |
|
Duplicates |