[MGNLDEMO-165] magnolia-travel-demo-multisite should depend on magnolia-travel-tours Created: 19/May/16  Updated: 19/May/22  Resolved: 19/May/22

Status: Closed
Project: Magnolia Demo Projects
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: benno baumgartner Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

cotoolz for magnolia reports two errors in magnolia-travel-demo-multisite:

  • Unknown template 'tours:components/tourDetailRelatedTours' /magnolia-travel-demo-multisite/src/main/resources/sportstation/templates/pages/tourSportstation.yaml
  • Unknown type 'info.magnolia.demo.travel.tours.model.TourDetailModel' /magnolia-travel-demo-multisite/src/main/resources/sportstation/templates/components/ tourDetailSportstation.yaml

tourDetailRelatedTours and TourDetailModel are both defined in magnolia-travel-tours but magnolia-travel-demo-multisite does not depend on magnolia-travel-tours. IMHO the reported errors are correct and multisite should depend on tours when it uses code from tours.

Adding this dependency to /magnolia-travel-demo-multisite/pom.xml fixes the problem:

    <dependency>
      <groupId>info.magnolia.demo</groupId>
      <artifactId>magnolia-travel-tours</artifactId>
    </dependency>


 Comments   
Comment by Roman Kovařík [ 19/May/22 ]

Hello,

This ticket is now marked as closed due to one of the following reasons:

  • A long period of inactivity
  • Uses an old or Beta version of an application, module, or framework that we no longer support
  • The issue is no longer reproducible or has been fixed in later versions

If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you.

Thank you,
The Magnolia Team

Generated at Mon Feb 12 05:16:57 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.