[MGNLDEMO-18] Rename current PageIntro to something else and less confusing Created: 05/May/15  Updated: 29/May/15  Resolved: 28/May/15

Status: Closed
Project: Magnolia Demo Projects
Component/s: None
Affects Version/s: 0.5
Fix Version/s: 0.5

Type: Bug Priority: Major
Reporter: Philip Mundt Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MTE-21 Page intro component Closed
relates to MGNLDEMO-52 Jumbotron dialog should extend TextIm... Open
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

PageIntro is not a page intro a thus should be renamed. A page intro should operate on page properties instead of contents.

We should call this element Jumbotron, because that's what it is.



 Comments   
Comment by Christian Ringele [ 06/May/15 ]

The page into is a component.
As written above, it should operate on page properties, so it should be:

  • either an area with createAreaNode=false
  • or being directly in the main script

I favor area because:

  • one can easily replace the script and its markup site wide or just for a page
  • one can provide its own dialog for it. Otherwise its all in the page properties dialog.

I'm currently working on a impl for demonstrating it, I'll add here the commit.

Comment by Christopher Zimmermann [ 28/May/15 ]

Renamed pageIntro to jumbotron. But leave it as a normal component that creates its own content under the page - instead of editing page content.
One wierd thing is that the dialog has the label "Text and Image" instead of "jumbotron". I think this is ok - and preferable to creating an entirely new dialog just to change the labels & description - as it demonstrates the current state of MTE component reuse.
When we have extends then we can extend the TextImage dialog and provide new labels/descriptions.

Added new ticket to that effect.

Generated at Mon Feb 12 05:15:28 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.