[MGNLDEMO-29] Use same way to generate links to tours throughout the demo Created: 08/May/15  Updated: 20/May/15  Resolved: 18/May/15

Status: Closed
Project: Magnolia Demo Projects
Component/s: magnolia-travels
Affects Version/s: 0.5
Fix Version/s: 0.5

Type: Bug Priority: Neutral
Reporter: Philip Mundt Assignee: Philip Mundt
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLDEMO-15 Rename contextAttribute 'tfn' to 'tou... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Currently we generate link in two different way:

info.magnolia.demo.travel.tours.service.TourServices#getTourLink(String): http://localhost:8080/magnoliaPublic/travel/tour?tour=West-Coast---Highway-101

info.magnolia.templating.functions.TemplatingFunctions#link(javax.jcr.Node): http://localhost:8080/magnoliaPublic/tours/Magnolia-Travels/West-Coast---Highway-101.html

We should be using the latter, only.



 Comments   
Comment by Christopher Zimmermann [ 18/May/15 ]

Implementation looks good.
tourList.ftl should also be updated.
Which looks like it requires getRelatedToursByCategory to return marshalled nodes.

Comment by Philip Mundt [ 18/May/15 ]

Fixed missing link by adding proper usage of link method.

Generated at Mon Feb 12 05:15:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.