[MGNLDEMO-297] Sample assets make no use of relevant metadata Created: 24/Aug/18  Updated: 17/May/19  Resolved: 25/Jan/19

Status: Closed
Project: Magnolia Demo Projects
Component/s: None
Affects Version/s: None
Fix Version/s: 1.4

Type: Task Priority: Neutral
Reporter: Maxime Michel Assignee: Antti Hietala
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 0.5d
Original Estimate: Not Specified

Attachments: PNG File caption-usage-in-textImage.png     PNG File caption-usage.png     PNG File shark.png    
Issue Links:
relation
is related to MGNLPER-44 Configurable result title property fo... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

As seen at the following URL's:

This has been made visible by MGNLPER-44, in which a search for an image showed me its 'caption' property, which was wrongly set to the image author.

We should use those properties correctly to make our demos more appealing and more accessible (think Braille readers).

This overhaul is needed for all assets, from tours (CE) to stories (EE).



 Comments   
Comment by Christopher Zimmermann [ 19/Sep/18 ]

I think the caption value is used in the travel demo templates.
If the caption values are changed, then the templates should also be updated.

Example: search for "Brian" on this page:
https://demopublic.magnolia-cms.com/travel/tour?tour=/magnolia-travels/Scuba-Diving-in-Bahamas--famed-Tiger-Beach

I'm not sure of the reason it was done that way in the past - I think there may have been some problems with accessing the DAM metadata from a template .

Comment by Maxime Michel [ 19/Sep/18 ]

I'm not sure of the reason it was done that way in the past - I think there may have been some problems with accessing the DAM metadata from a template .

Shouldn't that be verified (and solved?) as a prerequisite to this ticket then?

Comment by Antti Hietala [ 19/Sep/18 ]

Yes, caption is used in templates to render a credit to the photographer.

Let's say the new, more appropriate caption will read "Kleine Scheidegg hiking trails by Ed Coyle". In that case we may want to adjust the i18n label preceding it.

Current:
credit.leadImage=Lead image by

New:
credit.leadImage=Lead image

Comment by Maxime Michel [ 19/Sep/18 ]

Shouldn't "Kleine Scheidegg hiking trails by Ed Coyle" rather be a combination of the caption and author fields?

Comment by Antti Hietala [ 19/Sep/18 ]

Shouldn't "Kleine Scheidegg hiking trails by Ed Coyle" rather be a combination of the caption and author fields?

Yes, I think you are correct. Caption should rather describe what's in the photo, not who took it.

Btw, Dublin Core metadata (DCMI) doesn't have a caption property at all. This means we a free to define caption in a way that fits the travel demo site best.

On the other hand, we are limited by available space in the design. Here's another example of caption fallback in a Text & Image component:

 

I'll define a few meaningful captions and see if we can avoid having to change the templates.

Comment by Antti Hietala [ 18/Jan/19 ]

Reopened. The following fixes should be done:

  • Add a ".jpg" suffix back to asset node names. The suffix got somehow lost in a previous metadata update. A module version handler task (see MGNLDEMO-304) needs suffixed node names to apply tags.
  • Remove the dot character from the Halligen Island asset name flickr_halligen_jaym.s_14844840920_12546a2afe_k and fix its node type. The dot character causes the asset to be stored under a mgnl:content node in JCR, which also means that a user cannot not see the asset in the Assets app. The asset is hidden in tree and list views. (unrelated issue but let's fix it now)
Generated at Mon Feb 12 05:18:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.