[MGNLDEMO-361] Eric can edit & publish while Peter is powerless on apps without workflow Created: 10/Oct/14  Updated: 18/Aug/21  Resolved: 18/Aug/21

Status: Closed
Project: Magnolia Demo Projects
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Antti Hietala Assignee: Unassigned
Resolution: Obsolete Votes: 1
Labels: ux
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MAGNOLIA-5795 Reconfigure availability of de/activa... Closed
caused by MGNLUI-2939 Reconfigure availability of de/activa... Closed
dependency
is depended upon by MGNLTEST-63 Provide users, groups and roles used ... Closed
relation
is related to MGNLDEMO-30 Create users and roles for demonstrat... Closed
supersession
is superseded by MAGNOLIA-8156 Sane security defaults to onboard use... Selected
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Peter cannot publish pages in Community Edition. MGNLUI-2939 added a new availability constraint writePermissionRequired=true to activate and activateRecursive actions. This has the side effect that Peter, whose demo-project-publisher role doesn't permit him to write to the website workspace, cannot publish pages either.

This issue is specific to CE since it doesn't have workflow.

(In EE, Peter can approve a workitem. The new action availability constraint was not added to /modules/workflow/messageViews/publish/actions/approve.)


Update:
This was introduced with: MAGNOLIA-5795

In 4.5 we had workflow as part of CE and peter was never able to 'activate' anything on a workspace. He was only able to publish from workItems from the inbox.
As we changed this in 5.0 by removing workflow from CE, peter should now be able to publish in CE (which conflicts with his readOnly permission on the workspace).

One possible solution is to change the writePermissionRequired to 'false' in CE and switching it to 'true' when installing workflow for that app. which IMO is only an ugly workaround to a conceptual problem we're facing.

OTOH, why should peter be able to push something to a public instance (which is a much more harmful action) and not be able to publish (activate) something which is more likely do much less harm, than pushing it to public. My vote goes for reverting or at least change the default of the writePermssionRequired to 'false'.



 Comments   
Comment by Espen Jervidalo [ 15/Oct/14 ]

Peter is not able to publish in any apps anymore, except the app is using workflow or he accidentally has write permission on the workspace.
To reproduce on e.g. Assets app, go to demoauthor, login in as peter and try to publish an asset.

Comment by Mikaël Geljić [ 28/Oct/14 ]

Questions:

  • Should Peter remain unable to initiate publication when workflow is installed for an app (as in 4.5, as per write permissions, was the ground for SUPPORT-3625)
  • Eric can edit and publish on standard content apps, while Peter cannot do anything really.
    • Should Eric edit only, and Peter publish only (kind of manual workflow)?
  • This would lead to inconsistencies between apps with workflow installed and standard content apps, e.g.:
    • As Eric: "Why is publish enabled in Pages (via workflow), but not in Assets (plain activation)?"
    • Vice-versa as Peter: "Why is publish disabled in Pages, but enabled in Assets?"
    • As whoever: "What is the meaning of the publish action?" (will it go straight to public or not)

This issue has to be solved on UX level first, before we implement some silly workaround.
We could maybe communicate the different semantics better between those two flavors of publication, through appropriate phrasing of the actions.

Side note:
The difference is not so much about CE vs. EE, but rather whether or not workflow is installed for that app.

Generated at Mon Feb 12 05:18:55 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.