[MGNLDEMO-412] Remove magnolia-module-javascript-models from travel demo and bundle webapps Created: 12/Dec/22  Updated: 06/Jan/23  Resolved: 29/Dec/22

Status: Closed
Project: Magnolia Demo Projects
Component/s: None
Affects Version/s: None
Fix Version/s: 1.6.8

Type: Task Priority: Neutral
Reporter: Bartosz Staryga Assignee: Federico Grilli
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Release notes required:
Yes
Documentation update required:
Yes
Date of First Response:
Epic Link: Build on Java 17
Team: Foundation
Work Started:

 Description   

when running the magnolia community with a travel demo bundle, we found that the travel demo requires magnolia-module-javascript-models
That is the bundle we use for training and all our minimal demos.
The problem is that most people who attend our training or install minimal demos when they install Java install the newest ones - front end people just follow the java website.
the new Java does not have nashorn aka bundle does not work found that the reason why it's there is a `Math.random()` file in some place.
Could we revisit if we need this math a random bit? remove it completely or replace it with freemarker alternative? So we could get rid of javascript-models  dependency and make it easier and more clear for pd developer experience?

Slack thread about it: https://magnolia-cms.slack.com/archives/C02RDS0KBHQ/p1670848992634349

Notes

Does the magnolia-test-webapp even start without JS models? There might be a dependency.



 Comments   
Comment by Federico Grilli [ 30/Dec/22 ]

mdrapela /abrooks Highlight in release notes:

magnolia-module-javascript-models has been removed from Magnolia webapps but is still managed in the community bundle's parent pom.xml for all custom projects still depending on it.
Reason for the definitive removal is that using the latest LTS JDK 17 required some cumbersome exclusion of the module in order to work, since it is based on the Nashorn js engine which JDK has removed as of version 16.

Comment by Martin Drápela [ 03/Jan/23 ]

TODO: For the 6.2.28 release, we'll have to toggle this then: https://git.magnolia-cms.com/projects/DOCUMENTATION/repos/antora-site/browse/playbook.yml#385

therefore, marking the ticket as docu required too.

Generated at Mon Feb 12 05:19:26 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.