[MGNLDEMO-42] German translation for "template labels" Created: 19/May/15  Updated: 28/Nov/17  Resolved: 28/Oct/15

Status: Closed
Project: Magnolia Demo Projects
Component/s: None
Affects Version/s: None
Fix Version/s: 0.8

Type: Bug Priority: Major
Reporter: Christopher Zimmermann Assignee: Christoph Meier
Resolution: Fixed Votes: 0
Labels: 541backlog, pm, quickwin
Remaining Estimate: 0d
Time Spent: 1d
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLDEMO-30 Create users and roles for demonstrat... Closed
relates to LANG-69 Create german language property files... Accepted
dependency
depends upon LANG-35 Remove bundle files for travel-demo Closed
depends upon MGNLDEMO-114 Use i18n "best practices" on the trav... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Travel Demo
Sprint: Basel 16
Story Points: 2

 Description   

Translate all the "template labels" - the not JCR stored texts displayed on the pages visible for the website visitors.

All the other things for apps, dialogs and components should be tackled by follow-up ticket(s) when RenderableDefinition is properly i18n-ized.


Old description

At the very least the app labels should be translated. It looks very awkward when you open the tours app and see some strings in english and others in german.

We should demonstrate how magnolia can be translated for editors.
Create german language files for the demo components & dialogs.

There should be a user outofthebox which can be used to demonstrate this - probably provided in MGNLDEMO-30 ticket.

Files requiring translation:
/magnolia-travel-demo/src/main/resources/info/magnolia/module/travel-demo/messages_en.properties
/magnolia-travel-demo/src/main/resources/mgnl-i18n/module-travel-demo-messages_en.properties

/magnolia-travel-tours/src/main/resources/info/magnolia/module/travel-tours/messages_en.properties
/magnolia-travel-tours/src/main/resources/mgnl-i18n/app-tourCategories-messages_en.properties
/magnolia-travel-tours/src/main/resources/mgnl-i18n/app-tours-messages_en.properties



 Comments   
Comment by Christoph Meier [ 21/Oct/15 ]

The travel demo is using both "old i18n" and "new i18n" API mechanisms. Concerned modules are magnolia-travel-demo and magnolia-travel-tours.

For instance on magnolia-travel-demo there 3 resource bundles:
i - magnolia-travel-tours/src/main/resources/info/magnolia/module/travel-tours/messages
ii - magnolia-travel-tours/src/main/resources/mgnl-i18n/app-tourCategories-messages
iii - magnolia-travel-tours/src/main/resources/mgnl-i18n/app-tours-messages

i indeed is required, however most of its keys actually would / should go into one of the mgnl-i18n bundles.
Also note that all ('?') dialogs are both setting i18n basename - "best practice" here would be neither setting basename nor label / description but just using autogenerated keys and then setting the appropriate key/value pair within a mgnl-i18n bundle.

Refactoring that all would take some time - however, after a short discussion with ejervidalo we agreed in refactoring it. Fortunately all dialogs are YAML files - as a consequence no update task is required.

To split up the work a little bit - i create another ticket which just takes care about moving the keys to the "appropriate" bundles and using i18n best practice on the dialogs.

Generated at Mon Feb 12 05:15:42 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.