[MGNLDEMO-48] Use MTE PageProperties dialog and use it for navigation and window titles. Created: 26/May/15  Updated: 09/Jun/17  Resolved: 26/May/15

Status: Closed
Project: Magnolia Demo Projects
Component/s: None
Affects Version/s: 0.5
Fix Version/s: 0.5

Type: Improvement Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MTE-22 Create basic pageProperties dialog to... Closed
relation
is related to DOCU-1040 Fallbacking of ${content.windowTitle!... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

MTE-22 Introduces a pageProperties dialog. The defaultPageProperties in the demo should go away and this new MTE dialog used instead.
NavigationAreaModel should use the new navigationTitle property provided by the dialog.
main.ftl should use the new windowTitle property provided by the dialog.



 Comments   
Comment by Christopher Zimmermann [ 26/May/15 ]

Use mte pageProperties dialog
Remove defaultPageProperties dialog.
and implement windowTitle and navigationTitle properties.

Comment by Philip Mundt [ 27/May/15 ]

All good but two things:

  1. You assgin title = content.windowTitle!content.title but only use it in the <title>. I would not assign it and simply output above in the title. This would also be in-sync with what you've done in MTE-22.
  2. main-marketing-tags.ftl should be adjusted too
Comment by Christopher Zimmermann [ 27/May/15 ]

Implemented as suggested.

Generated at Mon Feb 12 05:15:46 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.