[MGNLDEMO-56] Final Tour content Created: 02/Jun/15  Updated: 04/Jun/15  Resolved: 03/Jun/15

Status: Closed
Project: Magnolia Demo Projects
Component/s: None
Affects Version/s: None
Fix Version/s: 0.5

Type: Improvement Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File whitespaces.png    
Issue Links:
Relates
relates to MGNLDEMO-35 Final page content Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Final tour content and assets.



 Comments   
Comment by Philip Mundt [ 03/Jun/15 ]
  • A quick check revealed that The Long Trail's image cannot be found anymore.
  • tours/templates/macros/sampleTourText.ftl misses the closing tags of <li>. I know HTML5 has optional closing tags, but we should have consistent HTML.
  • Why do you modify the macro for tourImage with additional (copyright) parameters when the expected parameter (assetRendition – info.magnolia.dam.api.AssetRendition) contains the Asset getAsset() method and therefore the properties you're passing?
  • Please make sure to not add whitespaces to templates/files in general (see: whitespaces.png)
  • Additionally I was wondering whether it wouldn't be nicer to have the same naming pattern (- or _) for DAM assets?
Comment by Christopher Zimmermann [ 03/Jun/15 ]

Fix is on branch MGNLDEMO-56-c.

  • * Added image for "The Long Trail" and the "Spectacular Ammouliani Island" which was also missing.
  • Added closing </li>'s
  • Changed image macro as suggested - I just didnt think of it. THought about also then getting the caption from the rendition - but seems to be best that its passed in so one can choose if one wants a caption or not.
  • True, asset naming could be more consistent - The bulk of the images were retrieved in two batches resulting in the main inconsistancy. names could be simplified as well. But I'd rather postpone that consideration for later.
Generated at Mon Feb 12 05:15:50 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.