[MGNLDEMO-82] When I browse the new demo site, I experience a nice modern design Created: 07/Jul/15  Updated: 27/Jul/15  Resolved: 22/Jul/15

Status: Closed
Project: Magnolia Demo Projects
Component/s: None
Affects Version/s: None
Fix Version/s: 0.6

Type: Story Priority: Neutral
Reporter: Philipp Bärfuss Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: pm
Σ Remaining Estimate: 0d Remaining Estimate: 0d
Σ Time Spent: 5d Time Spent: 5d
Σ Original Estimate: 3d Original Estimate: 3d

Attachments: PNG File demo.png    
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLDEMO-84 Add SVG assets for the destination icons Sub-task Closed Roman Kovařík  
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: Travel Demo
Sprint: Sprint 2 (Basel)
Story Points: 8

 Description   

Complete the implementation of the design from Aperto.
Lists by Destination
Lists by TourType
Destination header
TourType header
Hover effects
Destination icons



 Comments   
Comment by Marvin Kerkhoff [ 15/Jul/15 ]

actualy the edit view ist sometimes very strange jumping if you toggle green bars. Please also have a look at the footer social media icons in editview.

Comment by Christopher Zimmermann [ 16/Jul/15 ]

Note - commits are based on MGNLDEMO-84 commits.

Comment by Christopher Zimmermann [ 22/Jul/15 ]

Fix on MGNLDEMO-82-language-links
https://git.magnolia-cms.com/gitweb/?p=modules/demo-projects.git;a=shortlog;h=refs/heads/MGNLDEMO-82-language-links

Sorry for the big commit - but there was a lot to be done. It would be time-consuming to slice it into smaller discrete commits due to big changes in the CSS.

CHANGES:

DEVICE & BROWSER support

  • Tested on Chrome, Firefox, Safari, ie9+, Android Chrome, Mobile Safari.
  • ie8 not supported due to SVG issues.

General changes:

  • Favicon added and moved to themes.
  • Hero images are all "centered" and "cover".
  • Navigation hilighting is now blue underline.
  • Navigation dropdown styling improved.
  • Home Page: Tourtype Teasers are now icons.
  • Category & Tour pages: hero image fits exact window size.
  • Teasers cards: Entire card is anchor making site more app-like.
  • Featured Tour Cards: New style & hover effect.
  • Tour Cards: New style & hover effect.
  • Tour page: Product Info is now exactly at bottom of window, emphasizing image.
  • Tour page: Product Info: Destination & tourtype icons have hover effect.
  • Search results: Improved layout & removed rounded borders.
  • Shorted name of "Scuba diving at tiger beach".
  • Removed registered "R" mark from MagnoliaTravels logo.

Mobile changes:

  • Tour page: product info section gets smaller.
  • Tour page: info in header moves down so that Book Tour does not obscure info.
  • Footer Icons are smaller so that they fit 3 in a row, and stay small when device is narrow.
  • Homepage: carousel arrows are raised so that they are on screen.
  • Font size of headers shrink on small screens.
  • Navigation shrinks in height on narrow windows. (better for phone)

Behind the scenes:

  • Added js "viewport-units-buggyfill.js" to support vh pixel units.
  • Removed unused style declarations in css.
  • Removed unused stickynav js library.
  • Removed unused fonts from magnolia theme.
  • Removed unused images.

Sportstation:

  • Added favicon.
  • Updated menu styles.
  • Made TourType icons not visible on TourTeasers.

Models:

  • Changed getToursByCategory and getRelatedToursByCategory tor return Tour objects.
Comment by Federico Grilli [ 23/Jul/15 ]

As agreed during our brief chatting about MGNLDEMO-67 QA, here's a couple remarks which might be relevant for this issue

  • MGNLDEMO-67 the current selected language is plain text, while the other one is bold and on mouse over gets underlined
    • I'd put current language bold and the other plain text (still underlined on mouse over)
    • also I think they'd benefit from a separator like |

Comment by Christopher Zimmermann [ 23/Jul/15 ]

Rebased on Master to get the language links.
A few other tweaks:
shortening german names.
hidding overflow in cards.
left alignment of body text on tour details.
Including JS on the marketing tags main template.

Fix on MGNLDEMO-82-language-links
https://git.magnolia-cms.com/gitweb/?p=modules/demo-projects.git;a=shortlog;h=refs/heads/MGNLDEMO-82-language-links

Generated at Mon Feb 12 05:16:07 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.