[MGNLDIFF-100] Compare current with previous version is not aware of personalization Created: 09/Oct/17 Updated: 25/Oct/18 Resolved: 25/Oct/18 |
|
| Status: | Closed |
| Project: | Magnolia Diff Module |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Maxime Michel | Assignee: | Unassigned |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Story Points: | 5 | ||||||||
| Description |
|
When doing "Compare with previous version" on the travel demo home page, a broken diff is produced. Here are the steps to reproduce: 1. go to Pages After some investigation the issue seems to be caused by the "Featured Tour Types" personalised component which is hidden by default. In conclusion, the diff here is a result of personalisation variants (based on a cookie in this particular case) and we need to find a way to make the action aware of all personalisation variants for the page (and the components therein) being compared in order to produce the correct diff output. |
| Comments |
| Comment by Antti Hietala [ 22/Jan/18 ] |
|
The broken diff view can be resolved by changing how component variants are composed on travel home. Delete the Featured Tours by Tour Type component and make it a variant of Tour Type Teaser Row.
However, the workaround does not prevent a customer from potentially composing the same problematic component scenario on their own. A permanent fix requires changing how we render diffs.
|