[MGNLDIFF-103] Show changes fails silenty in some cases Created: 16/May/18  Updated: 01/Sep/21  Resolved: 01/Sep/21

Status: Closed
Project: Magnolia Diff Module
Component/s: None
Affects Version/s: 2.0
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Viet Nguyen Assignee: Unassigned
Resolution: Won't Fix Votes: 0
Labels: maintenance
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Magnolia MKG subscription package, Corp website


Issue Links:
causality
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

As described in CLOUDHELP-86, compare Versions in the Pages app displays only a blank screen.

eg. https://author-live-magnolia-mkg.de.magnolia-now.com/.magnolia/admincentral#app:pages:diff;/.magnolia/versionDiff?diffViewContentHandle=/www-en-intl&fromVersionNr=1.81&toVersionNr=1.79&diffLocale=en

After investigation, we recognized that underlying FTL was changed, which caused some errors when displaying previous versioned content.

"if you change its layout and its underlying implementation, the previous version cannot be displayed anymore, then we can't compare."

Basically currently we just provided 'content' comparison, not totally page comparison. Also rendering errors didn't displayed properly --> this should be fixed first.

Also below information might help when fixing this issue:

yellow freemarker errors are being displayed only on author instances out of the box. To be sure, I’ve just tested and it works. But they are displayed only if 'mgnlPreview' is set to false, which is standard behaviour in Pages app but 'compare versions' functionality comparing a page (probably) against a page in preview mode.

Without freemarker error: https://author-live-magnolia-mkg.de.magnolia-now.com/www-en-intl/?mgnlVersion=1.82
With freemarker error (see the last parameter) https://author-live-magnolia-mkg.de.magnolia-now.com/www-en-intl/?mgnlVersion=1.82&mgnlPreview=false



 Comments   
Comment by Viet Nguyen [ 01/Sep/21 ]

We will not invest in this function if user change his FTL and do the comparison during the time. We will consider open another ticket in case of other issue happen. Let's close this here to clean up our pipeline as this issue has been reported since 2018.

Generated at Mon Feb 12 05:21:24 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.