[MGNLDIFF-111] Version Comparison URL Bug when no .html ending is supported Created: 10/Nov/21 Updated: 20/Dec/21 Resolved: 17/Dec/21 |
|
| Status: | Closed |
| Project: | Magnolia Diff Module |
| Component/s: | None |
| Affects Version/s: | 2.2.1 |
| Fix Version/s: | 2.2.2 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Carlos Cantalapiedra | Assignee: | Jaroslav Simak |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | VN-Maintenance, maintenance | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 0.5d | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||
| Issue Links: |
|
||||
| Template: | |||||
| Acceptance criteria: |
Empty
|
||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||
| Bug DoR: |
[X]*
Steps to reproduce, expected, and actual results filled
[X]*
Affected version filled
|
||||
| Date of First Response: | |||||
| Sprint: | Global Maintenance 3 | ||||
| Story Points: | 5 | ||||
| Description |
Steps to reproduce
Expected resultsThe Diff module shows changes between versions Actual resultsAn empty screen is shown with apache httpd error. WorkaroundN/A Development notesThe VersionDiffHtmlServlet.java forces the html ending (hardcoded), it should be taken dynamically from config (e.g, from defaultExtension attribute) VersionDiffHtmlServlet.java private String getSourceUrl(HttpServletRequest request, String contentHandle) { String baseUrl = StringUtils.substringBefore(request.getRequestURL().toString(), SERVICE_PATH); return baseUrl + contentHandle + ".html"; } |